Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement chunky uploads #6931

Merged
merged 7 commits into from
Oct 25, 2024
Merged

Implement chunky uploads #6931

merged 7 commits into from
Oct 25, 2024

Conversation

ShanaLMoore
Copy link
Contributor

@ShanaLMoore ShanaLMoore commented Oct 24, 2024

Fixes

Issue

Summary

Chunked uploads allow large files to be uploaded in smaller parts, addressing common issues with file size limits, network interruptions, and server resource management.

This change supports smoother, more reliable uploads for large files in Hyrax.

Guidance for testing, such as acceptance criteria or new user interface behaviors:

  • Manually upload large files when creating or editing a work
  • The upload should succeed as long as its size is under the configure threshold

image

@samvera/hyrax-code-reviewers

@ShanaLMoore ShanaLMoore added the notes-minor Release Notes: Non-breaking features label Oct 24, 2024
@ShanaLMoore ShanaLMoore changed the title I865 implement chunky uploads Implement chunky uploads Oct 24, 2024
Copy link

github-actions bot commented Oct 25, 2024

Test Results

    17 files  ±0      17 suites  ±0   2h 18m 35s ⏱️ + 1m 21s
 6 717 tests +3   6 420 ✅ +3  297 💤 ±0  0 ❌ ±0 
13 204 runs  +6  12 808 ✅ +6  396 💤 ±0  0 ❌ ±0 

Results for commit 0f75098. ± Comparison against base commit e11d5d0.

This pull request removes 274 and adds 277 tests. Note that renamed tests count towards both.
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f0f0e51cbc8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f913648e260>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f0f0e8d5dc8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f9136a3f650>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: c5581b9d-5f87-4ca0-bb40-c402252e4616
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 408c4791-cad3-4671-8811-259111d4c82d
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: bec84e8f-1074-4f28-91dd-e5ae0675e372
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: ebf9bd2a-60cd-4b2b-b572-1466a1fef4f8
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: babadee6-44e9-43a8-b98c-a0edee5811dc
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: bd2bae10-c843-457d-9d14-d895987c0384
…
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fb1caaee100>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fd4c82b85c8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fb1cd7b5508>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fd4c82beb08>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: ab723028-3640-42b2-9761-560e5c43ea80
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: bfa7b078-1d3f-4856-bdb7-9c45ce33ee80
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 21de975c-ff25-46d3-85ab-07bbbe8ec352
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 5c120019-f85b-4db7-92ad-580137c2248c
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 6d3e776e-62ab-4a6d-a626-7df2556b1dbf
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 82a269d6-2ee8-48d3-a332-863c80115f8d
…

♻️ This comment has been updated with latest results.

@ShanaLMoore ShanaLMoore merged commit 583ae3f into main Oct 25, 2024
22 checks passed
@ShanaLMoore ShanaLMoore deleted the i865-implement-chunky-uploads branch October 25, 2024 19:34
ShanaLMoore added a commit to scientist-softserv/adventist_knapsack that referenced this pull request Oct 30, 2024
# Summary

Updates submodule to pull in chunk upload support from hyrax.

Issue:
- #856
(HYRAX)



ref:
- samvera/hyrax#6931 (HYRAX)
- samvera/hyku#2371
@dlpierce dlpierce mentioned this pull request Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes-minor Release Notes: Non-breaking features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants