-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement chunky uploads #6931
Merged
Merged
Implement chunky uploads #6931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is also backwards compatible and enables chunked uploading of Hyrax files.
Test Results 17 files ±0 17 suites ±0 2h 18m 35s ⏱️ + 1m 21s Results for commit 0f75098. ± Comparison against base commit e11d5d0. This pull request removes 274 and adds 277 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
orangewolf
approved these changes
Oct 25, 2024
dlpierce
approved these changes
Oct 25, 2024
This was referenced Oct 28, 2024
ShanaLMoore
added a commit
to scientist-softserv/adventist_knapsack
that referenced
this pull request
Oct 30, 2024
# Summary Updates submodule to pull in chunk upload support from hyrax. Issue: - #856 (HYRAX) ref: - samvera/hyrax#6931 (HYRAX) - samvera/hyku#2371
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Issue
Summary
Chunked uploads allow large files to be uploaded in smaller parts, addressing common issues with file size limits, network interruptions, and server resource management.
This change supports smoother, more reliable uploads for large files in Hyrax.
Guidance for testing, such as acceptance criteria or new user interface behaviors:
@samvera/hyrax-code-reviewers