Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for adapters #493

Closed
wants to merge 8 commits into from
Closed

Prepare for adapters #493

wants to merge 8 commits into from

Conversation

ro0gr
Copy link
Collaborator

@ro0gr ro0gr commented Mar 29, 2020

This PR is focused on the:

A noticeable difference to ExecutionContexts is that Adapter is no longer responsible for the Element search logic, which requires an action to find the element before passing it to adapter.

of the #479.

Also in this PR we drop findElementWithAssert code as not needed anymore.

@ro0gr ro0gr force-pushed the prepare-for-adapters branch from 9fefb6e to 8e20854 Compare March 29, 2020 20:40
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.8%) to 96.625% when pulling 8e20854 on ro0gr:prepare-for-adapters into 0c209b4 on san650:v2-beta.

@ro0gr
Copy link
Collaborator Author

ro0gr commented May 9, 2020

close in favour of #509

@ro0gr ro0gr closed this May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ro0gr @coveralls