-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nightly build failures #1092
Comments
A fix is coming up soon |
I believe there are new errors from omegah + Kokkos: https://sems-cdash-son.sandia.gov/cdash//build/312099/configure . There were others on mockba and camobap which I fixed already but those won't show up until tomorrow in the nightlies. |
Yeah, Kokkos 4.5.0 was snapshot into Trilinos yesterday |
Is someone working on fixing it? |
Looks like omega_h has a requirement for kokkos 3.7 here: https://github.com/SCOREC/omega_h/blob/94aa915568abb01c169fc5b84bbbd12acede8935/CMakeLists.txt#L60 I assume this would need to be updated to reflect the new version. Edit: tagging @cwsmith in case he hasn't seen this thread |
I turned off omega_h on blake for now. There are a lot of failing tests on weaver... |
Most of landice tests failing with NAN residuals. I'll try to have a look in the afternoon. |
at least most of the gpu tests are also failing on cpu. there are a few exceptions:
|
yeah, let's start fixing the tests on cpus |
Thanks @mcarlson801 . My local build of omegah (SCOREC/omega_h@94aa915) with the kokkos (4.5.00) cuda backend was successful. Can someone post, or email me, the omegah relevant portions of the build log? |
looks like it's a configure issue:
|
I'm looking at this on cpu as well so I'll let you know if I find anything before then. |
A PR for fixing the Omega_h configure issue is here: #1095. |
I've looked into it a bit, and it seems that fields are not loaded correctly and can contain garbage. That's all I was able to figure out for today. |
maybe some incompatibility with @bartgol custom dual view classes? |
I will have to check next week. |
I don't see anything wrong in the code. The only think I can think of is that the dyn rank view may have the wrong size... But I don't see why that would happen. I need to dig a bit. |
I dug a little deeper into LoadStateField and it looks like we can rule out sync issues with the state data dual view and issues with the MDField iterator. All three fields in LoadStateField are in agreement, it's just the data is bad. From albany-serial-bad (LandIce_FO_Dome_Ascii):
From albany-serial-good (LandIce_FO_Dome_Ascii):
|
Interesting. So the issue is that the field is probably never correctly loaded into the STK structures when the mesh is created? |
Apparently linear access of Kokkos dynamic rank views is no longer working
Couple builds broken this morning. It looks like it's due to recent PRs. @mperego do you want to take a look?
The text was updated successfully, but these errors were encountered: