fix(menu-item): allow setting role attribute`

sanity-io · Dec 11, 2024 · a06bd80 · a06bd80
1 parent edc85bd
commit a06bd80
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/core/components/menu/menuItem.tsx b/src/core/components/menu/menuItem.tsx
@@ -118,6 +118,7 @@ export const MenuItem = forwardRef(function MenuItem(
   return (
     <Selectable
       data-ui="MenuItem"
+      role="menuitem"
       {...restProps}
       aria-pressed={as === 'button' && pressed}
       data-pressed={as !== 'button' && pressed ? '' : undefined}
@@ -133,7 +134,6 @@ export const MenuItem = forwardRef(function MenuItem(
       onMouseEnter={onItemMouseEnter}
       onMouseLeave={onItemMouseLeave}
       ref={setRef}
-      role="menuitem"
       tabIndex={-1}
       type={as === 'button' ? 'button' : undefined}
     >