Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scan pay back 7 - clean #4171

Open
wants to merge 109 commits into
base: master-qa
Choose a base branch
from
Open

Scan pay back 7 - clean #4171

wants to merge 109 commits into from

Conversation

cabch
Copy link
Contributor

@cabch cabch commented Apr 4, 2023

No description provided.

mahdibenromdhane and others added 30 commits November 2, 2022 16:29
Scan and pay first look
09614ad
scan and pay first look
5209794
commit to merge
3e994a8
Merge remote-tracking branch 'origin/master-qa' into scan-pay-back
3eb3266
@cabch
Merge branch 'master-qa' into scan-pay-back
b6eb4bd
@cabch
send email with verify button
f8b6e89 
click the button send to /scan-pay with email name firstname siteareid
@cabch
need to clear interfaces
de3aeae
@cabch
commented send email dev env
7148c86
capture method payment
b8affcc
@cabch
comments to complete the flow
62814e8 
handleScanAndPaySetupPaymentMethod will handle user creation for the POC // à améliorer
+ verify the http request
@cabch
Merge branch 'master-qa' into scan-pay-back
9c289f5 
 especially if it merges an updated upstream into a topic branch.
@cabch
scan pay create user + email working + createpaymentintent
463bfa1
separate setupPaymentMethod from setupPaymentIntent
b42e04c
create virtual tag when scan-pay
3652f34
start transaction scan pay
2c0ca16
Merge remote-tracking branch 'origin/master-qa' into scan-pay-back
0391ce7
@cabch
- changed scanAndPay to scanPay
fb4f54c 
- added subdomain with Subdomain = pas sure de celui la c'est un peu naze de devoir faire ça, on ferait pas mieux de garder le Subdomain ?
- capture still there -> need to get rid of it
- changed routes to billing/scan-pay

+ merge with mahdi's work
@cabch
handle tag error
e801b14
@cabch
Merge branch 'master-qa' into scan-pay-back
cef54ac
@cabch
added connector id and charging station id for testing purpose
2d5652a
@cabch
renamed capture as we don't capture for the moment
2568c9a
@cabch
cleaned capture -> retrieve
37e5219
@cabch
required fields en trop
83be255
@cabch
added new role external in auth def
8ec1456 
commented what needs to be changed
save user role + status user scan pay creation
@cabch
forgot to push external role in athorizations ...
03f0378
Save payment intent Id in transaction
53d7b9a
Merge remote-tracking branch 'origin/master-qa' into scan-pay-back
ea1994e
@cabch
first try on stopping transaction
8b2e9ed 
but it does not work YET !
@cabch
Merge branch 'master-qa' into scan-pay-back
0687949
@cabch
modified connector id -> transactionId
d702f34
ClaudeROSSI
ClaudeROSSI suggested changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@ClaudeROSSI ClaudeROSSI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few comments!

src/assets/server/rest/v1/schemas/billing/billing-scan-pay.json Outdated Show resolved Hide resolved
src/authorization/AuthorizationsDefinition.ts Show resolved Hide resolved
src/notification/NotificationHandler.ts Outdated Show resolved Hide resolved
src/notification/NotificationHandler.ts Outdated Show resolved Hide resolved
src/server/rest/v1/service/AuthService.ts Outdated Show resolved Hide resolved
src/integration/billing/stripe/StripeBillingIntegration.ts Outdated Show resolved Hide resolved
src/integration/billing/stripe/StripeBillingIntegration.ts Outdated Show resolved Hide resolved
src/integration/billing/stripe/StripeBillingIntegration.ts Outdated Show resolved Hide resolved
src/integration/billing/stripe/StripeBillingIntegration.ts Outdated Show resolved Hide resolved
src/integration/billing/stripe/StripeBillingIntegration.ts Outdated Show resolved Hide resolved
Ramzay
Ramzay requested changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@Ramzay Ramzay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check my remarks ;)

@cabch
forgot commented return
0a2a671 
modified read authorizations
@cabch
Copy link
Contributor Author

cabch commented Apr 24, 2023

everything has been modified as pointed out ✅

cabch
cabch commented Apr 24, 2023
View reviewed changes
Copy link
Contributor Author

@cabch cabch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modifications done ✅

@cabch cabch requested a review from Ramzay April 24, 2023 15:17
cabch
cabch commented Apr 24, 2023
View reviewed changes
Copy link
Contributor Author

@cabch cabch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything has been modified as pointed out ✅

@cabch cabch requested a review from ClaudeROSSI April 24, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ramzay Ramzay Awaiting requested review from Ramzay

@ClaudeROSSI ClaudeROSSI Awaiting requested review from ClaudeROSSI

Requested changes must be addressed to merge this pull request.

Assignees

@cabch cabch

@mahdibenromdhane mahdibenromdhane

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cabch @CLAassistant @Ramzay @ClaudeROSSI @mahdibenromdhane