-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: (IAC-619) Support VPCs with private and control_plane subnets, NAT gateway is not required #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhoucgitter
added
enhancement
New feature or request
documentation
Improvements or additions to documentation
labels
Oct 9, 2023
riragh
reviewed
Oct 17, 2023
thpang
requested changes
Oct 18, 2023
dhoucgitter
commented
Oct 19, 2023
dhoucgitter
commented
Oct 20, 2023
jarpat
requested changes
Oct 25, 2023
…er review comment
…onal variable column updates
dhoucgitter
force-pushed
the
fix/iac-619
branch
from
October 25, 2023 15:08
3552ea6
to
9c520f7
Compare
Add expected ingress rules to main SG, cluster SG and workers SG for new private CIDR vars
canpmh
reviewed
Oct 25, 2023
canpmh
reviewed
Oct 25, 2023
- add depends relationship for objects relying on API access
thpang
reviewed
Oct 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking for logic clarity
jarpat
requested changes
Oct 27, 2023
thpang
requested changes
Oct 31, 2023
…net_ids map clearer, include subnet_ids link
canpmh
reviewed
Oct 31, 2023
thpang
approved these changes
Nov 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jarpat
approved these changes
Nov 2, 2023
riragh
approved these changes
Nov 2, 2023
dhoucgitter
changed the title
feat: (IAC-619) Support VPCs with ONLY private subnets, NAT gateway is not required
feat!: (IAC-619) Support VPCs with ONLY private subnets, NAT gateway is not required
Nov 2, 2023
dhoucgitter
changed the title
feat!: (IAC-619) Support VPCs with ONLY private subnets, NAT gateway is not required
feat!: (IAC-619) Support VPCs with private and control_plane subnets, NAT gateway is not required
Dec 5, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
private_dns_enable=true
and add security group rule to allow access to AWS ECR container images from a private networkvpc_private_access_cidrs
andvm_private_access_cidrs
, anddefault_private_access_cidrs
configuration variables and add doc for them and existingcluster_endpoint_private_access_cidrs
This update includes breaking changes and updates managed security groups and their rules. Existing EC2 instances and their network interfaces with references to the original security groups creates obstacles for direct replacement of those security groups. Users with infrastructure created with the v7.2.1 release or older will need to destroy their cluster using the version of viya4-iac-aws used to create their infrastructure and then recreate it with the latest release.
The current recommendation for users who want to use the release containing this PR and created their infrastructure for a Viya deployment with viya4-iac-aws:7.2.1 or earlier is to:
Tests
tests are being recorded in the internal ticket during testing