Suggestion: Don't create final DB snapshot when destroying Amazon RDS instance #243
Conversation
|
@AWSmith0216, thanks for the PR suggestion. I noticed that behavior cleaning up some AWS resources recently and discussed some options with Thomas. We had decided to expose the skip_final_snapshot as an optional configuration parameter but default it to true instead of false since that is the current behavior and we anticipate that production environments may still want that db snapshot insurance. That would still allow folks to override it to false to prevent automatic db snapshot generation. Does that seem like a reasonable compromise? |
|
@dhoucgitter , providing a configuration parameter to control the snapshot behavior works for me. Thanks |
|
Created internal ticket IAC-1241 to provide this feature. |
|
@AWSmith0216, thanks for submitting this PR and sharing your proposed changes with the team. |
While using viya4-iac-aws to provision an Amazon RDS instance, I noticed that a database snapshot is created when doing a 'terraform destroy'. The user doesn't really have any way to know that this snapshot is created, and it will persist indefinitely until the user manual deletes it. Personally, when doing a 'terraform destroy', I would expect all resources to be removed, or at least some indication that something is being left behind.
It looks like the rds module provides a skip_final_snapshot flag which can be used to control this behavior. This PR simply sets this flag to true by default rather than false.