Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: (IAC-1190) Update Providers, Modules, & Binaries #246

Merged
merged 7 commits into from
Nov 29, 2023
Merged

Conversation

jarpat
Copy link
Contributor

@jarpat jarpat commented Nov 17, 2023

Changes

Made updates to the binaries, providers, and modules in the viya4-iac-aws project to resolve warnings that came from our Aqua security scan.

This is a "breaking change" but compatible with the upcoming viya4-iac-aws:8.0.0 release provided users take the time to run "terraform init -upgrade" before they run apply again. Users of the docker image will have the updated binaries, providers, and modules if they rebuild it using the dockerfile.

Version Updates

Binaries

  • Terraform 1.4.5 -> 1.6.3
  • AWS CLI 2.11.21 -> 2.13.33
  • kubectl 1.26.7 > 1.26.10

Providers

hashicorp/aws
hashicorp/kubernetes

Modules

terraform-aws-modules/eks/aws
terraform-aws-modules/rds/aws
  • Versions:
    • Initial Version: 5.9.0
    • Final Version: 6.2.0
      • Notes:
        • Outputs have been updated, db_instance_id -> db_instance_identifier
        • Outputs have been updated, db_instance_password -> removed
        • Outputs have been updated, create_random_password -> removed
        • New variable enabled by default manage_master_user_password, no matter the password provided will generate a random password and use AWS Secrets Manager, setting to false to keep current behavior.
  • Change Log: https://github.com/terraform-aws-modules/terraform-aws-rds/blob/master/CHANGELOG.md
terraform-aws-modules/iam/aws//modules/iam-assumable-role-with-oidc

Tests

Scenario Provider Task K8s Version Order Cadence Notes
1 AWS OOTB - Docker v1.26.10-eks-4f4795d ***** fast:2020
2 AWS OOTB - Terraform on Host v1.26.10-eks-4f4795d ***** fast:2020
3 AWS OOTB with 8.0.0 -> Upgrade K8s with PR v1.26.10-eks-4f4795d -> v1.27.7-eks-4f4795d ***** fast:2020

@jarpat
Copy link
Contributor Author

jarpat commented Nov 17, 2023

Note for reviewers, cluster_id was deprecated where it no longer blocks until terraform is able to communicate with the cluster and no longer returns a value unless you are using AWS Outposts. The recommendation was to directly get those values from module.eks rather than using the aws_eks_cluster data object here which allows for the "block" to reintroduced.

So the code was changed a bit, but functionally no changes.

See L61 and in locals.
https://github.com/sassoftware/viya4-iac-aws/pull/246/files#diff-dc46acf24afd63ef8c556b77c126ccc6e578bc87e3aa09a931f33d9bf2532fbbL20

@jarpat jarpat self-assigned this Nov 17, 2023
@jarpat jarpat added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 17, 2023
@jarpat jarpat merged commit 18f616c into staging Nov 29, 2023
3 checks passed
@jarpat jarpat deleted the IAC-1190 branch November 29, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants