feat!: (IAC-1190) Update Providers, Modules, & Binaries #246
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Made updates to the binaries, providers, and modules in the viya4-iac-aws project to resolve warnings that came from our Aqua security scan.
This is a "breaking change" but compatible with the upcoming
viya4-iac-aws:8.0.0
release provided users take the time to run "terraform init -upgrade" before they runapply
again. Users of the docker image will have the updated binaries, providers, and modules if they rebuild it using the dockerfile.Version Updates
Binaries
Providers
hashicorp/aws
hashicorp/kubernetes
Modules
terraform-aws-modules/eks/aws
cluster_id
will no longer return a value, will need to be replaced withcluster_name
iam_role_additional_policies
needs to be a map. The key can be any unique string while the value is the policy.node_security_group_enable_recommended_rules
, new variable that set to true to introduces some recommended security group rules. See second bullet point here to see what it allows https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/docs/UPGRADE-19.0.md#added. Since we already setnode_security_group_additional_rules
with our own rules, will be setting this value to false.create_kms_key
, is now to set to true by default, setting the value to false to retain our previous behaviorcluster_encryption_config
now has values set by default, setting to an empty list to retain our previous behavior.terraform-aws-modules/rds/aws
db_instance_id
->db_instance_identifier
db_instance_password
-> removedcreate_random_password
-> removedmanage_master_user_password
, no matter the password provided will generate a random password and use AWS Secrets Manager, setting to false to keep current behavior.terraform-aws-modules/iam/aws//modules/iam-assumable-role-with-oidc
Tests