Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: (IAC-1380) AWS Autoscaling Launch Template Tags Incorrect #282

Merged
merged 1 commit into from
Apr 12, 2024
Merged

fix: (IAC-1380) AWS Autoscaling Launch Template Tags Incorrect #282

merged 1 commit into from
Apr 12, 2024

Conversation

dhoucgitter
Copy link
Member

@dhoucgitter dhoucgitter commented Apr 11, 2024 •
edited
Loading

Changes

  • Update the k8s.io/cluster-autoscaler key and tag values for the default_node_pool and the user_node_pool to align them with what is expected.

Tests

  • Verify that the EC2 node instances created by the Auto Scaling Group include the two updated k8s.io/cluster-autoscaler key and tag values made under this PR. Details are included in the testing assets file available in the internal ticket.
Provider K8S Version TF input file region Notes
AWS 1.28 terraform-input-byongp3.tfvars us-west-1 Both updated k8s.io/cluster-autoscaler/* Tag key and value pairs are present after cluster create as desired. See assets zip file on internal ticket for command output details and Terraform input file content.

@dhoucgitter dhoucgitter self-assigned this Apr 11, 2024
@dhoucgitter dhoucgitter marked this pull request as draft April 11, 2024 19:37
@dhoucgitter dhoucgitter marked this pull request as ready for review April 11, 2024 21:47
@dhoucgitter dhoucgitter changed the base branch from main to staging April 11, 2024 21:48
@dhoucgitter dhoucgitter added the bug Something isn't working label Apr 12, 2024
thpang
thpang approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@thpang thpang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dhoucgitter dhoucgitter merged commit 177d152 into staging Apr 12, 2024
4 checks passed
@dhoucgitter dhoucgitter deleted the fix/iac-1380 branch April 12, 2024 20:43
@dhoucgitter dhoucgitter mentioned this pull request Apr 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riragh riragh riragh approved these changes

@jarpat jarpat jarpat approved these changes

@thpang thpang thpang approved these changes

@sayeun sayeun Awaiting requested review from sayeun

Assignees

@dhoucgitter dhoucgitter

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dhoucgitter @thpang @jarpat @riragh