Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Elaborate code review process in CONTRIBUTING.md #304

Merged
merged 1 commit into from
Sep 18, 2024
Merged

docs: Elaborate code review process in CONTRIBUTING.md #304

merged 1 commit into from
Sep 18, 2024

Conversation

semioticrobotic
Copy link
Contributor

This PR adds to CONTRIBUTING.md additional detail about the project team's code review process.

@semioticrobotic semioticrobotic added the documentation Improvements or additions to documentation label Sep 18, 2024
dhoucgitter
dhoucgitter approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@dhoucgitter dhoucgitter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

saschjmil
saschjmil approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@saschjmil saschjmil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

riragh
riragh approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@riragh riragh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dhoucgitter dhoucgitter merged commit f724af3 into main Sep 18, 2024
4 checks passed
@dhoucgitter dhoucgitter deleted the semioticrobotic-contributing-patch-aws branch September 18, 2024 17:20
@dhoucgitter dhoucgitter changed the title Elaborate code review process in CONTRIBUTING.md docs: Elaborate code review process in CONTRIBUTING.md Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riragh riragh riragh approved these changes

@saschjmil saschjmil saschjmil approved these changes

@dhoucgitter dhoucgitter dhoucgitter approved these changes

@iadomi iadomi Awaiting requested review from iadomi

Assignees

@dhoucgitter dhoucgitter

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@semioticrobotic @dhoucgitter @saschjmil @riragh