Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: (IAC-1024) Update IAC Sample Sizing #387

Merged
merged 4 commits into from
Jun 12, 2024
Merged

feat: (IAC-1024) Update IAC Sample Sizing #387

merged 4 commits into from
Jun 12, 2024

Conversation

jarpat
Copy link
Contributor

@jarpat jarpat commented Jun 11, 2024 •
edited
Loading

Changes

Updated examples, defaults, and docs to line up with sizing recommendations.

Tests

Scenario Provider Example File kubernetes_version Order Cadence
1 Azure sample-input.tfvars v1.28.9 * fast:2020
2 Azure sample-input-connect.tfvars v1.28.9
3 Azure sample-input-defaults.tfvars v1.28.9
4 Azure sample-input-minimal.tfvars v1.28.9
5 Azure sample-input-ppg.tfvars v1.28.9
6 Azure sample-input-singlestore.tfvars v1.28.9

@jarpat jarpat changed the title WIP Sizing Updates feat: (IAC-1024) Update IAC Sample Sizing Jun 12, 2024
@jarpat jarpat self-assigned this Jun 12, 2024
@jarpat jarpat added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 12, 2024
@jarpat jarpat marked this pull request as ready for review June 12, 2024 18:12
thpang
thpang approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@thpang thpang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as long as the machines provided have more capacity all around than the machines they are replacing.

dhoucgitter
dhoucgitter approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@dhoucgitter dhoucgitter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jarpat jarpat merged commit 06e5070 into staging Jun 12, 2024
3 checks passed
@jarpat jarpat deleted the IAC-1024 branch June 12, 2024 20:16
@jarpat jarpat mentioned this pull request Jun 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thpang thpang thpang approved these changes

@dhoucgitter dhoucgitter dhoucgitter approved these changes

@saschjmil saschjmil Awaiting requested review from saschjmil

Assignees

@jarpat jarpat

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jarpat @dhoucgitter @thpang