Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: (PSKD-704) Update refs to GCP in Docs #221

Merged
merged 2 commits into from
Sep 12, 2024
Merged

docs: (PSKD-704) Update refs to GCP in Docs #221

merged 2 commits into from
Sep 12, 2024

Conversation

riragh
Copy link
Member

@riragh riragh commented Sep 12, 2024

Google naming conventions have changed. Google Cloud Platform is now called Google Cloud. This PR makes the required updates to adhere the new naming convention wherever applicable.
See more details here: https://cloud.google.com/blog/topics/developers-practitioners/introducing-new-homepage-google-cloud

@riragh riragh added the documentation Improvements or additions to documentation label Sep 12, 2024
@riragh riragh requested a review from supear September 12, 2024 15:10
@riragh riragh self-assigned this Sep 12, 2024
@riragh riragh changed the title (PSKD-704) Update refs to GCP in Docs docs: (PSKD-704) Update refs to GCP in Docs Sep 12, 2024
saschjmil
saschjmil previously approved these changes Sep 12, 2024
Copy link
Contributor

@supear supear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few changes are needed.

docs/CONFIG-VARS.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/user/DockerUsage.md Outdated Show resolved Hide resolved
docs/user/TerraformGCPAuthentication.md Outdated Show resolved Hide resolved
docs/user/TerraformGCPAuthentication.md Outdated Show resolved Hide resolved
docs/user/TerraformUsage.md Outdated Show resolved Hide resolved
@riragh
Copy link
Member Author

riragh commented Sep 12, 2024

Just a few changes are needed.

Made all the suggested changes. Ready for re-review.

@riragh riragh requested review from saschjmil and supear September 12, 2024 16:44
Copy link
Contributor

@saschjmil saschjmil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest changes look good to me

@riragh riragh merged commit 2ccb8a5 into main Sep 12, 2024
3 checks passed
@riragh riragh deleted the PSKD-704 branch September 12, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants