Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: (IAC-1334) Add a variable and set a default for the kube-vip-cloud-provider version #108

Merged
merged 3 commits into from
Feb 5, 2024

Conversation

jarpat
Copy link
Contributor

@jarpat jarpat commented Feb 5, 2024

Changes

Add a new kube_vip_cloud_provider_version variable to control the kube-vip-cloud-provider version
https://github.com/kube-vip/kube-vip-cloud-provider

The default is set to v0.0.8 as that has been tested to work.

Tests

Scenario Provider K8s Version kube_vip_cloud_provider_version Order Cadence
1 OSS v1.28.6 default (v0.0.8) *** fast:2020
2 OSS v1.28.6 main *** fast:2020

Closes #104

Copy link
Member

@thpang thpang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jarpat jarpat merged commit 45d548b into staging Feb 5, 2024
4 checks passed
@jarpat jarpat deleted the IAC-1334 branch February 5, 2024 19:59
@jarpat jarpat mentioned this pull request Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
4 participants