-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: (IAC-1484) Update IAC Sample Sizing #126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking for clarification and possible code changes.
cpus = 16 | ||
memory = 131072 | ||
os_disk = 350 | ||
misc_disks = [ | ||
150, | ||
150, | ||
400, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be careful here. The 2 different disk are used for 2 different items. Though they look the same they are needed separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll message you about this, there may be something about the misc_disks
that I'm not aware of.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These misc disks are used by the static provisioner and not set asside for use with CASCACHE unless it uses the static provisioner to map that storage into the nodes.
cpus = 16 | ||
memory = 131072 | ||
cpus = 4 | ||
memory = 16384 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought compute needed 128G of memory to run items there. Interesting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's based off their testing and it also lines up with the SAS Doc that states 16 is the min for compute for a "SAS Viya" deployment
https://go.documentation.sas.com/doc/en/itopscdc/v_052/itopssr/n0ampbltwqgkjkn1j3qogztsbbu0.htm#n11a8r150qgkcon17txx5r526sd9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, it may be the min but if they are hoping for a more dynamic system on bare-metal or VMs this will not happen. So the resources needed for the compute need to be there from the very beginning.
cpus = 16 | ||
memory = 131072 | ||
os_disk = 350 | ||
misc_disks = [ | ||
150, | ||
150, | ||
400, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These misc disks are used by the static provisioner and not set asside for use with CASCACHE unless it uses the static provisioner to map that storage into the nodes.
cpus = 16 | ||
memory = 131072 | ||
cpus = 4 | ||
memory = 16384 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, it may be the min but if they are hoping for a more dynamic system on bare-metal or VMs this will not happen. So the resources needed for the compute need to be there from the very beginning.
Summary of changes post-review comments:
I'll need to do a quick test and I'll ask for another review afterwards. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good as long as the number here reflect a real-world scenario and their maximum values where applicable given the static nature of bare-metal/vm deployments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changes
Updated examples, defaults, and docs to line up with sizing recommendations.
Tests