Move modified HPA alert to kube-prometheus-stack helm chart values #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rename the KubeHpaMaxedOut alert to KubeHpaMaxedOutMultiPod * Include deployment of this alert in kube-prometheus-stack helm chart Signed-off-by: Tobias Wackenhut <[email protected]>
|
@tynsh Thank you for (re)submitting this PR. We'll merge it in after a quick review. |
gsmith-sas
approved these changes
Dec 13, 2023
|
@tynsh Thank you for contributing your fix to improve how we handle defining alerts. We have now merged your contribution into the 'main' branch of the project which will make it available to other users. We expect it will be part of our next formal release (expected in mid-January). As you pointed out in the original issue (#575), our original approach made it difficult for users to modify the default list of alerts and now, with your contribution, this should be much easier. So, thank you for making this project better! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-applies the changes from PR #580 with an entry to the changelog and a commit signoff.
Fixes #575