Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove ghosttunnel from grafana and use default tls config #618

Merged
merged 5 commits into from
Mar 12, 2024
Merged

remove ghosttunnel from grafana and use default tls config #618

merged 5 commits into from
Mar 12, 2024

Conversation

ceelias
Copy link
Collaborator

@ceelias ceelias commented Feb 29, 2024

No description provided.

@ceelias ceelias requested a review from gsmith-sas March 1, 2024 15:12
gsmith-sas
gsmith-sas approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@gsmith-sas gsmith-sas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gsmith-sas
gsmith-sas requested changes Mar 1, 2024
View reviewed changes
Copy link
Member

@gsmith-sas gsmith-sas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still Need:

  • CHANGELOG.md entry
  • Remove ghostunnel from component_versions.env
  • Update ARTIFACT_INVENTORY.template (in internal project)

UPDATE (05MAR24): You are correct, these last two are not needed. Sorry for the noise.

gsmith-sas
gsmith-sas reviewed Mar 6, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@ceelias ceelias requested a review from gsmith-sas March 6, 2024 17:56
gsmith-sas
gsmith-sas approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@gsmith-sas gsmith-sas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ceelias ceelias merged commit 0f96bce into main Mar 12, 2024
1 check passed
@ceelias ceelias deleted the remove-ghostunnel-graf branch March 12, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmith-sas gsmith-sas gsmith-sas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ceelias @gsmith-sas