Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve breaking changes by AG Grid 33 #1335

Merged
merged 1 commit into from
Dec 20, 2024
Merged

fix: resolve breaking changes by AG Grid 33 #1335

merged 1 commit into from
Dec 20, 2024

Conversation

scnwwu
Copy link
Member

@scnwwu scnwwu commented Dec 19, 2024

Summary
Fix #1334
Resolve breaking changes introduced by AG Grid v33

Testing
See data table correctly

@scnwwu scnwwu requested review from scottdover and scnjdl December 19, 2024 05:15
@scnwwu scnwwu changed the title fix: adopt AG Grid 33 fix: resolve breaking changes by AG Grid 33 Dec 19, 2024
@scnwwu scnwwu added this to the 1.13.0 milestone Dec 19, 2024
@enzhihpp enzhihpp assigned tianliang657 and unassigned enzhihpp Dec 19, 2024
@tianliang657 tianliang657 added testing-complete Complete the pull requests testing and removed verification-needed labels Dec 20, 2024
tianliang657
tianliang657 approved these changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@tianliang657 tianliang657 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue is fixed in the playpen sas extension, please see the attached video "Fixed.gif" for the details, no other issues were found, so approving.
Fixed

@scnwwu scnwwu merged commit 24cf415 into sassoftware:main Dec 20, 2024
2 checks passed
@scnwwu scnwwu deleted the p-aggrid33 branch December 20, 2024 03:05
@tianliang657 tianliang657 added ready for release Code pushed, but not released in VS code marketplace yet and removed testing-complete Complete the pull requests testing labels Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boyce-w boyce-w boyce-w approved these changes

@tianliang657 tianliang657 tianliang657 approved these changes

@scottdover scottdover Awaiting requested review from scottdover

@scnjdl scnjdl Awaiting requested review from scnjdl

Assignees

@tianliang657 tianliang657

Labels
ready for release Code pushed, but not released in VS code marketplace yet
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

There is no data when open a table at libraries pane
4 participants
@scnwwu @tianliang657 @boyce-w @enzhihpp