Use a new slugify function #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-slugger omitted emojis from slugs, which means that tags like "🌱-my-tag" will be transformed into "-my-tag"
satnaing
approved these changes
Aug 19, 2024
|
LGTM |
|
@satnaing thank you for creating this project! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Replace
github-sluggerwithlodash.kebabcaseSometimes you need to create tags with emojis like "🌱-my-tag" as shown in the screenshot below. With
github-sluggerthe emoji will be removed from the tag and will be shown as-my-taginstead. github-slugger docsLive example of this change: https://www.alejandro.dev/posts/building-the-wrong-thing/