-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for SEP-0007 pay and transaction requests #1202
Open
ebma
wants to merge
38
commits into
master
Choose a base branch
from
feature/support-sep7-requests
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when it is opened by the PaymentAccountSelectionDialog
Co-authored-by: Andy Wermke <[email protected]>
The onCancel prop was not used before so now it indicates whether the payment form should show a dismiss button or not
Setting padding-right and -left to zero removes the shadows and looks weird
which combines handling payment and transaction requests
7 tasks
ebma
changed the title
Support SEP-0007 pay and transaction requests
Add support for SEP-0007 pay and transaction requests
Jan 25, 2021
Good work! We really need this in our DAO! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #1179.
transactionRequest
context (to parse and store incoming SEP-0007 requests)<TransactionRequestHandler>
that checks theuri
stored in thetransactionRequest
context and shows dialogs according to its content<VerifyTrustedServiceDialog>
that is shown for incoming SEP-0007 requests that have anorigin_domain
but are not in the list of trusted services. The user can then decide to trust this domain and it will be added to the list of trusted services.<PaymentRequestContent>
that renders an inline payment form and account selection list<TransactionRequestContent>
that renders a transaction summary and an account selection list, either for selecting the source account (if a source account -replacement is defined) or for selecting the signing account<StellarRequestReviewDialog>
that will render thePaymentRequestContent
orTransactionRequestContent
based on the type of the incoming SEP-0007 request.preselectedParams
as a prop to the<PaymentForm>
to be able to pre-fill the respective input fields with values of thepay
request. Pre-filled input fields will be disabled so that the user cannot change the value.localStorage
in web build (makes it easier to test trusted services but is useful in general)<NoAccountsDialog>
that is shown if no accounts are available for the network specified in the SEP-0007 requestCloses #323.
Sample SEP-0007 requests can be found here and here.
Payment request:
Transaction request:
No accounts: