try PNG instead of ICO (copy saucelabs.com)

saucelabs · Aug 2, 2024 · bde50ee · bde50ee
1 parent 01d64a8
commit bde50ee
Show file tree

Hide file tree

Showing 4 changed files with 31 additions and 6 deletions.
diff --git a/docusaurus.config.js b/docusaurus.config.js
@@ -8,9 +8,9 @@ const docusaurusConfig = {
     baseUrl: '/',
     onBrokenLinks: 'throw',
     onBrokenMarkdownLinks: 'throw',
-    favicon: 'favicon.ico',
     organizationName: 'saucelabs',
     projectName: 'sauce-docs',
+    // TODO: I don't think google-site-verification is working at all, confirm with P.O.
     customFields: {
         headTags: [
             {
@@ -22,6 +22,26 @@ const docusaurusConfig = {
             },
         ],
     },
+    headTags: [
+        {
+            tagName: 'link',
+            attributes: {
+                rel: 'icon',
+                type: 'image/png',
+                sizes: '16x16',
+                href: '/img/favicon-16x16.png',
+            },
+        },
+        {
+            tagName: 'link',
+            attributes: {
+                rel: 'icon',
+                type: 'image/png',
+                sizes: '32x32',
+                href: '/img/favicon-32x32.png',
+            },
+        },
+    ],
     scripts: [
         '/scripts/hide.js',
         // Need Help? button

diff --git a/sidebars.js b/sidebars.js
@@ -1695,7 +1695,7 @@ module.exports = {
                         'visual-testing/workflows/test-execution',
                         'visual-testing/workflows/review',
                         'visual-testing/workflows/ci',
-                        'visual-testing/workflows/api-lifecycle'
+                        'visual-testing/workflows/api-lifecycle',
                     ],
                 },
                 {

diff --git a/static/404.html b/static/404.html
@@ -4,10 +4,15 @@
         <title>404 Error | Sauce Docs</title>
         <link rel="stylesheet" href="/css/404.css" />
         <link
-            data-react-helmet="true"
-            rel="shortcut icon"
-            href="/img/favicon.ico"
-        />
+            rel="icon"
+            type="image/png"
+            href="/img/favicon-32x32.png"
+            sizes="32x32" />
+        <link
+            rel="icon"
+            type="image/png"
+            href="/img/favicon-16x16.png"
+            sizes="16x16" />
     </head>
     <body>
         <div class="container">

diff --git a/static/favicon.ico b/static/favicon.ico