Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sauce Visual API lifecycle #2867

Merged
merged 15 commits into from
Jul 29, 2024
Merged

Sauce Visual API lifecycle #2867

merged 15 commits into from
Jul 29, 2024

Conversation

kb-kerem
Copy link
Contributor

Description

To help customers that don’t rely on a technology we provide a binding for, we provide a (basic) documentation of Sauce Visual API lifecycle.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation fix (typos, incorrect content, missing content, etc.)

@github-actions GitHub Actions
Copy link

Deploy preview ready for 2867!
https://docs.dev.saucelabs.net
built from c540018

@github-actions GitHub Actions
Copy link

Deploy preview ready for 2867!
https://docs.dev.saucelabs.net
built from ec2428e

@github-actions GitHub Actions
Copy link

Deploy preview ready for 2867!
https://docs.dev.saucelabs.net
built from be9f406

@github-actions GitHub Actions
Copy link

Deploy preview ready for 2867!
https://docs.dev.saucelabs.net
built from e5282c6

@github-actions GitHub Actions
Copy link

Deploy preview ready for 2867!
https://docs.dev.saucelabs.net
built from 49514df

@github-actions GitHub Actions
Copy link

Deploy preview ready for 2867!
https://docs.dev.saucelabs.net
built from e6a32ed

@github-actions GitHub Actions
Copy link

Deploy preview ready for 2867!
https://docs.dev.saucelabs.net
built from 90302eb

@github-actions GitHub Actions
Copy link

Deploy preview ready for 2867!
https://docs.dev.saucelabs.net
built from 1ba41a3

FriggaHel
FriggaHel reviewed Jul 25, 2024
View reviewed changes
docs/visual-testing/workflows/api-lifecycle.md Outdated Show resolved Hide resolved
docs/visual-testing/workflows/api-lifecycle.md Show resolved Hide resolved
docs/visual-testing/workflows/api-lifecycle.md Show resolved Hide resolved
docs/visual-testing/workflows/api-lifecycle.md Outdated Show resolved Hide resolved
docs/visual-testing/workflows/api-lifecycle.md Outdated Show resolved Hide resolved
docs/visual-testing/workflows/api-lifecycle.md Outdated Show resolved Hide resolved
docs/visual-testing/workflows/api-lifecycle.md Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Deploy preview ready for 2867!
https://docs.dev.saucelabs.net
built from efa5d7e

@kb-kerem
Copy link
Contributor Author

@konraddysput @FriggaHel I've addressed all the points you've raised. Would appreciate another review.

@kb-kerem kb-kerem requested a review from FriggaHel July 26, 2024 13:15
@github-actions GitHub Actions
Copy link

Deploy preview ready for 2867!
https://docs.dev.saucelabs.net
built from c64326f

@github-actions GitHub Actions
Copy link

Deploy preview ready for 2867!
https://docs.dev.saucelabs.net
built from 3b66c71

@github-actions GitHub Actions
Copy link

Deploy preview ready for 2867!
https://docs.dev.saucelabs.net
built from 41026ef

@github-actions GitHub Actions
Copy link

Deploy preview ready for 2867!
https://docs.dev.saucelabs.net
built from f7c03e1

@github-actions GitHub Actions
Copy link

Deploy preview ready for 2867!
https://docs.dev.saucelabs.net
built from 09000dc

omacranger
omacranger approved these changes Jul 28, 2024
View reviewed changes
Copy link
Member

@omacranger omacranger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me.

@kb-kerem kb-kerem merged commit bc9f054 into main Jul 29, 2024
7 checks passed
@kb-kerem kb-kerem deleted the sauce-visual-api-lifecycle branch July 29, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FriggaHel FriggaHel FriggaHel approved these changes

@konraddysput konraddysput konraddysput approved these changes

@omacranger omacranger omacranger approved these changes

@paweltomaszewskisaucelabs paweltomaszewskisaucelabs Awaiting requested review from paweltomaszewskisaucelabs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kb-kerem @omacranger @konraddysput @FriggaHel