Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't let beamer change favicon url #2868

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Don't let beamer change favicon url #2868

merged 1 commit into from
Jul 25, 2024

Conversation

gmegidish-saucelabs
Copy link
Collaborator

Description

Disable Beamer modification of favicon

Motivation and Context

Google indexes the wrong icon

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation fix (typos, incorrect content, missing content, etc.)

discombobulateme
discombobulateme approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@discombobulateme discombobulateme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ufff impressive finding

@github-actions GitHub Actions
Copy link

Deploy preview ready for 2868!
https://docs.dev.saucelabs.net
built from c6fac3d

@gmegidish-saucelabs gmegidish-saucelabs merged commit 7ecf678 into main Jul 25, 2024
6 checks passed
@gmegidish-saucelabs gmegidish-saucelabs deleted the gm-disable-beamer-favicon-change branch July 25, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@discombobulateme discombobulateme discombobulateme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gmegidish-saucelabs @discombobulateme