Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Network Capture with new system-wide solution #2919

Merged
merged 10 commits into from
Sep 3, 2024

Conversation

yuyi-sl
Copy link
Contributor

@yuyi-sl yuyi-sl commented Aug 30, 2024

Description

New system-wide network capture feature.

Motivation and Context

Update documentation to reflect the new solution.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation fix (typos, incorrect content, missing content, etc.)

@yuyi-sl yuyi-sl requested a review from kristofmuhi as a code owner August 30, 2024 14:58
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

vale

docs/mobile-apps/features/network-capture.md|91 col 6| [sauce.Headings] 'Requests table' should use title case capitalization.
docs/mobile-apps/features/network-capture.md|102 col 139| [sauce.EOLWhitespace] Remove whitespace characters from the end of the line.
docs/mobile-apps/features/network-capture.md|106 col 6| [sauce.Headings] 'Waterfall chart' should use title case capitalization.
docs/mobile-apps/features/network-capture.md|111 col 6| [sauce.Headings] 'Request details' should use title case capitalization.
docs/mobile-apps/features/network-capture.md|112 col 144| [sauce.EOLWhitespace] Remove whitespace characters from the end of the line.
docs/mobile-apps/features/network-capture.md|117 col 136| [sauce.EOLWhitespace] Remove whitespace characters from the end of the line.
docs/mobile-apps/features/network-capture.md|217 col 6| [sauce.Headings] 'iOS' should use title case capitalization.

docs/mobile-apps/features/network-capture.md Show resolved Hide resolved
docs/mobile-apps/features/network-capture.md Show resolved Hide resolved
docs/mobile-apps/features/network-capture.md Outdated Show resolved Hide resolved
docs/mobile-apps/features/network-capture.md Show resolved Hide resolved
docs/mobile-apps/features/network-capture.md Outdated Show resolved Hide resolved
docs/mobile-apps/features/network-capture.md Show resolved Hide resolved
docs/mobile-apps/features/network-capture.md Outdated Show resolved Hide resolved
docs/mobile-apps/features/network-capture.md Show resolved Hide resolved
docs/mobile-apps/features/network-capture.md Show resolved Hide resolved
docs/mobile-apps/features/network-capture.md Outdated Show resolved Hide resolved
docs/mobile-apps/features/network-capture.md Outdated Show resolved Hide resolved
docs/mobile-apps/features/network-capture.md Show resolved Hide resolved
Copy link

Deploy preview ready for 2919!
https://docs.dev.saucelabs.net/pr-preview/pr-2919

1 similar comment
Copy link

Deploy preview ready for 2919!
https://docs.dev.saucelabs.net/pr-preview/pr-2919

Copy link

Deploy preview ready for 2919!
https://docs.dev.saucelabs.net/pr-preview/pr-2919

Copy link

Deploy preview ready for 2919!
https://docs.dev.saucelabs.net/pr-preview/pr-2919

Copy link

Deploy preview ready for 2919!
https://docs.dev.saucelabs.net/pr-preview/pr-2919

docs/mobile-apps/features/network-capture.md Show resolved Hide resolved
5. For Automated Testing only: add the networkCapture capability to your test script. Click the link below corresponding to your framework:

- [Appium](/dev/test-configuration-options/#saucelabsnetworkcaptureenabled)
- [Espresso via saucectl](/mobile-apps/automated-testing/espresso-xcuitest/espresso/#networkcapture)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets call out this comes later

groupId="dc-url"
defaultValue="us"
values={[
{label: 'United States', value: 'us'},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we even us-east?! hahaha

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a myth

docs/mobile-apps/features/network-capture.md Outdated Show resolved Hide resolved
- [Appium](/dev/test-configuration-options/#saucelabsnetworkcaptureenabled)
- [Espresso via saucectl](/mobile-apps/automated-testing/espresso-xcuitest/espresso/#networkcapture)
- [XCUITest via saucectl](/mobile-apps/automated-testing/espresso-xcuitest/xcuitest/#networkcapture)
For Android devices, a minor modification in the manifest is necessary, but all required changes will be handled by us. This means no
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets call out here that we need to modify the manifest file and call out this to ensure the SSL pinning is disabled, and that our certificate is accepted.
additionally call out we need the debug version of their app, and make sure that in the secureSDK repackaging prevention is disabled

Copy link

Deploy preview ready for 2919!
https://docs.dev.saucelabs.net/pr-preview/pr-2919

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments.

docs/mobile-apps/features/network-capture.md Outdated Show resolved Hide resolved
docs/mobile-apps/features/network-capture.md Show resolved Hide resolved
Copy link

github-actions bot commented Sep 2, 2024

Deploy preview ready for 2919!
https://docs.dev.saucelabs.net/pr-preview/pr-2919

Copy link

github-actions bot commented Sep 3, 2024

Deploy preview ready for 2919!
https://docs.dev.saucelabs.net/pr-preview/pr-2919

@yuyi-sl yuyi-sl merged commit ff3d039 into main Sep 3, 2024
5 checks passed
@yuyi-sl yuyi-sl deleted the real-time-network-capture branch September 3, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants