Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

little code modernization #57

Merged
merged 2 commits into from
Jun 12, 2024
Merged

little code modernization #57

merged 2 commits into from
Jun 12, 2024

Conversation

Lightning-
Copy link
Contributor

@Lightning- Lightning- commented Jun 12, 2024

this:

  • adds a dependency to puppetlabs/stdlib (to be able to use ensure_resource())
  • does some code optimizations/modernizations:
    • adds some param descriptions for puppet strings
    • improves datatypes
    • aligns a little bit more to styleguide (enum quotation e.g.)
    • replaces the ruby-alike function call each by the corresponding puppet function call
    • removes the if defined(Class[]) construction (as it might not be reliable) and uses ensure_resource() instead (in that context)

@Lightning- Lightning- marked this pull request as draft June 12, 2024 14:44
@Lightning- Lightning- marked this pull request as ready for review June 12, 2024 14:53
@saz saz merged commit bffc33f into saz:master Jun 12, 2024
18 checks passed
@saz
Copy link
Owner

saz commented Jun 12, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants