Fix context menu selection when selectionStart/SelectionEnd are missing

Fixes #55
sblask-webextensions · Mar 27, 2021 · 84b8914 · 84b8914
1 parent 879bde7
commit 84b8914
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/content-scripts/insert-item.js b/content-scripts/insert-item.js
@@ -9,12 +9,12 @@ function insertItemListener(message) {
 }
 
 function insertItem(node, item) {
-    if (node.selectionStart == undefined || node.selectionEnd == undefined) {
-        return;
-    }
+    // some pages seem to override/reset selectionStart/selectionEnd
+    const selectionStart = node.selectionStart || 0;
+    const selectionEnd = node.selectionEnd || node.value.length;
 
-    const beforeCursorOrSelection = node.value.slice(0, node.selectionStart);
-    const afterCursorOrSelection = node.value.slice(node.selectionEnd, node.value.length);
+    const beforeCursorOrSelection = node.value.slice(0, selectionStart);
+    const afterCursorOrSelection = node.value.slice(selectionEnd, node.value.length);
     node.value = beforeCursorOrSelection + item + afterCursorOrSelection;
     const detail = {
         simpleFormFillCustomInputEvent: true,