Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: support compilation with libxml2 2.12.0 #358

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

mtasaka
Copy link
Contributor

@mtasaka mtasaka commented Nov 30, 2023

Description

libxml2 2.12.0 now makes xmlGetLastError() return const pointer:
https://gitlab.gnome.org/GNOME/libxml2/-/commit/45470611b047db78106dcb2fdbd4164163c15ab7

Fix variable type using xmlGetLastError() as such.

Closes #357 .

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Change in documentation

Checklist:

  • I have updated all documentation necessary.
  • I have checked spelling in (new) comments.

Testing

  • Testing is done automatically and codecov shows test coverage
  • This cannot be tested automatically

libxml2 2.12.0 now makes xmlGetLastError() return const pointer:
https://gitlab.gnome.org/GNOME/libxml2/-/commit/45470611b047db78106dcb2fdbd4164163c15ab7

Fix variable type using xmlGetLastError() as such.

Closes sbmlteam#357 .
Copy link
Member

@fbergmann fbergmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the PR!

@fbergmann fbergmann merged commit a3e2178 into sbmlteam:development Dec 7, 2023
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error: invalid conversion from ‘const xmlError*’
2 participants