Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow FBC objects to be used in both L3v1 and L3v2 core documents. #362

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Allow FBC objects to be used in both L3v1 and L3v2 core documents. #362

merged 1 commit into from
Aug 5, 2024

Conversation

luciansmith
Copy link
Member

Fixes #360

Some objects already didn't check the version, and some didn't check the level, either. This standardizes on just checking the package version.

Doesn't fix anything for other packages, just FBC.

fbergmann
fbergmann approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@fbergmann fbergmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, I would prefer libSBML would do way less checking before setting the things that API calls want to set. And I don't think rejecting API calls should ever be made.

The changes you propose work fine.

thanks

@fbergmann fbergmann merged commit 94fa3fb into development Aug 5, 2024
33 of 35 checks passed
@fbergmann fbergmann deleted the fix-issue-360-fbc-in-l3v2-docs branch August 5, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbergmann fbergmann fbergmann approved these changes

@skeating skeating Awaiting requested review from skeating

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FBC: Can't make package version 3 object in L3v2 core model.
2 participants
@luciansmith @fbergmann