Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sk/small fixes #392

Draft
wants to merge 7 commits into
base: development
Choose a base branch
from
Draft

Sk/small fixes #392

wants to merge 7 commits into from

Conversation

skeating
Copy link
Member

@skeating skeating commented Aug 26, 2024

Description

Fixes #367
Fixes #379

  • Need to fix failing tests in packages-

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Change in documentation

Checklist:

  • I have updated all documentation necessary.
  • I have checked spelling in (new) comments.

Testing

  • Testing is done automatically and codecov shows test coverage
  • This cannot be tested automatically

@skeating skeating requested a review from fbergmann August 26, 2024 13:18
@skeating skeating marked this pull request as ready for review August 26, 2024 13:18
@skeating skeating marked this pull request as draft August 26, 2024 14:13
Copy link
Member

@fbergmann fbergmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skeating unfortunately, more files will need to be renamed. The following tests with packages fail:

	 14 - test_extension_package_groups_run (Failed)
	 21 - test_multi_validator_run (Failed)
	 22 - test_extension_package_qual_run (Failed)
Errors while running CTest

@skeating
Copy link
Member Author

yes I know this extra fails that's why it's a draft pull request and I put an additional checkbox in that description 😸

@skeating skeating requested a review from fbergmann August 29, 2024 12:14
Copy link
Member

@fbergmann fbergmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skeating the multi test still seems to fail with:

21: Testing General XML Consistency Constraints (20000 - 29999).
21: 
21: Error: 7020306-fail-01-01-10102.xml
21:   - Failures:  Expected: 2  Actual: 1
21: 
21: 
21: Error: 7020306-fail-01-01-10102.xml
21:   - Constraints:  Expected: 7020306  Actual: 
21: 7020306 
Error: e 9: (multi-20306 [Error]) There may be at most one ListOfCompartmentReferences container object within a Compartment object.
21: Reference: L3V1 Multi V1.1 Section 3.5.3
21:  Extended <compartment> may only have one <multi:listOfCompartmentReferences>

there is only one error reported, so it might need to be renamed as well?

@skeating skeating requested a review from fbergmann August 30, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants