Move generated source into "main" rather than "scala" #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to match the convention used by other plugins such as scalate
|
If this is the correct behavior, I definitely support this change since sbt-idea marks the scala directory as excluded, while the main directory is marked as source, so this is a very welcome change. |
|
Calling @aloiscochard :) |
|
+1 ...would make it play nicer with IntelliJ too |
|
+1 for this change |
|
@SandroGrzicic did you take this project over? Would be awesome if you did! |
| @@ -56,7 +56,7 @@ object ScalaBuffPlugin extends Plugin { | |||
| ): Seq[File] = { | |||
| val input = source / "protobuf" | |||
| if (input.exists) { | |||
| val output = sourceManaged / "scala" | |||
| val output = sourceManaged / "main" | |||
There was a problem hiding this comment.
shouldn't this go into sourceManaged / "main" / "scala" ?
|
first, thanks for setting this plugin up for scalabuff. Can we please have this PR integrated (with the comment I put their addressed)? I'm using this and for some reason (may be a bug) IDEA is not picking up the code unless its in sourceManaged/main/scala but sbt seems to be ok with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to match the convention used by other plugins such as scalate. I'm not sure if you want this change but it puts the files from scalabuff in the same tree as various other plugins...