Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding FUNDING.yml #374

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

julien51
Copy link

As an Open Source project, we @unlock-protocol believe Solidity Coverage should have a FUNDING.yml file which lets people make donations if they use the software, like we do ;)

This pull requests adds donation thru an Unlock lock. Locks are smart contract which let people become members by purchasing a key. The key itself is a non fungible token: 🗝 .

You can make a donation (and purchase a key!) on this page (linked inside of the FUNDING.yml file)

This specific lock is at 0x28f7cd2232778dd70F3C758546F3444568baC06d. The curent key price is 1 DAI. I currently own the lock but I'll happily transfer its ownership to you if you can send me an address ;) After that, you will be able to update the price, the name and withdraw the funds from the Unlock dashboard.

Keys are valid for 1 month and there can be an infinite number of keys.

PS: if you want to create your own FUNDING.yml link you can easily with this application.

@codecov-io
Copy link

Codecov Report

Merging #374 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #374   +/-   ##
=======================================
  Coverage   91.66%   91.66%           
=======================================
  Files           6        6           
  Lines         372      372           
  Branches       79       79           
=======================================
  Hits          341      341           
  Misses         31       31

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2e687b...43a7eb6. Read the comment docs.

1 similar comment
@codecov-io
Copy link

Codecov Report

Merging #374 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #374   +/-   ##
=======================================
  Coverage   91.66%   91.66%           
=======================================
  Files           6        6           
  Lines         372      372           
  Branches       79       79           
=======================================
  Hits          341      341           
  Misses         31       31

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2e687b...43a7eb6. Read the comment docs.

@julien51
Copy link
Author

One quick addition, when/if you merge this you also need to enable donations in the settings (see https://github.com/sc-forks/solidity-coverage/settings) :

image

@julien51
Copy link
Author

julien51 commented Sep 3, 2019

Hello @cgewecke ! I'd love to get your feedback on that one (I know you merged a similar PR on a repo that you own!). We blogged about the motivations behind that PR.

One of the next steps that we're thinking of is to create some kind of "shared" lock between many Ethereum OSS projects. The idea is that people can then chose to support a single project, like Ethlint, or the whole ethereum OSS ecosystem. This shared lock would belong to some kind of shared address (or even a DAO) to organize the funds and maybe distribute them to specific projects.

Anyway, my point is that I'd love to kick off a discussion here :)

@cgewecke
Copy link
Member

cgewecke commented Sep 3, 2019

@julien51 Hi, apologies for the delay in reviewing.

In fact, this project has two maintainers and I've kept forgetting to ping @area and ask him about how we should approach this question. Tbh my plan was just to message him a mnemonic but I like the 'shared lock' idea too.

There are some dependencies like solidity-parser-antlr (without which this tool & the gas-reporter would not work) that should be funded but probably only a small number of tools developers realize how critical that package is. A shared lock might be a nice way for utilities like this one to distribute whatever sponsorship there is more equitably - e.g towards lower visibility but high value projects.

@julien51
Copy link
Author

julien51 commented Sep 9, 2019

There are some dependencies like solidity-parser-antlr (without which this tool & the gas-reporter would not work) that should be funded but probably only a small number of tools developers realize how critical that package is.

We're of course more than happy to help them add buttons too!

A shared lock might be a nice way for utilities like this one to distribute whatever sponsorship there is more equitably - e.g towards lower visibility but high value projects.

Can't agree more! Here's an idea we're exploring. What do you think?

@mejango
Copy link

mejango commented Mar 20, 2022

Can we start a Juicebox project for this solidity-coverage? I'd love to help sustain the project, and happy to help keep an organized treasury for you. (juicebox.money)

(I help build the juicebox protocol and we use solidity-coverage)

@cgewecke
Copy link
Member

Hi @mejango! Thanks so much. I'll take a look at juicebox. :)

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.66%. Comparing base (c2e687b) to head (43a7eb6).
Report is 368 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #374   +/-   ##
=======================================
  Coverage   91.66%   91.66%           
=======================================
  Files           6        6           
  Lines         372      372           
  Branches       79       79           
=======================================
  Hits          341      341           
  Misses         31       31           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@Setland34 Setland34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants