Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirgrated to null safety #61

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

Mayb3Nots
Copy link

No description provided.

@xmine64
Copy link

xmine64 commented May 3, 2021

It doesn't work. I tested it today.

@Mayb3Nots
Copy link
Author

It doesn't work. I tested it today.

Hi can you include some error logs on to where it didnt work?

@xmine64
Copy link

xmine64 commented May 4, 2021

E/flutter (12844): [ERROR:flutter/lib/ui/ui_dart_state.cc(186)] Unhandled Exception: type 'Future<dynamic>' is not a subtype of type 'FutureOr<List<dynamic>>' in type cast
E/flutter (12844): #0      FlutterAudioQuery.getSongs (package:flutter_audio_query/src/flutter_audio_query.dart:187:8)
E/flutter (12844): #1      ... (my code)
E/flutter (12844): #2      ... (my code)

@Mayb3Nots
Copy link
Author

Mayb3Nots commented May 5, 2021

E/flutter (12844): [ERROR:flutter/lib/ui/ui_dart_state.cc(186)] Unhandled Exception: type 'Future<dynamic>' is not a subtype of type 'FutureOr<List<dynamic>>' in type cast
E/flutter (12844): #0      FlutterAudioQuery.getSongs (package:flutter_audio_query/src/flutter_audio_query.dart:187:8)
E/flutter (12844): #1      ... (my code)
E/flutter (12844): #2      ... (my code)

Hi @mmdmine can you now try again with the latest commit?
Please make sure that the reference in your pubspec.lock is this ebf6ca5cdde20768b3b1bca1ebab54f9fa6bcac5. If not, delete the file and then run flutter pub get

@TcBello
Copy link

TcBello commented May 10, 2021

Hi @Mayb3Nots I've also tried it yesterday but even though I delete the pubspec.lock and double check your ebf6ca5 and run flutter pub get it stil doesn't work it is still the same error

@Mayb3Nots
Copy link
Author

@TcBello After double checking it seems like I missed some of the FutureOR. Please try again with this commit 9cd3ce1ba71d3cdaf455ea0a1d6fa70ef29fba7a

@TcBello
Copy link

TcBello commented May 10, 2021

@Mayb3Nots it's now working thank you

@TcBello
Copy link

TcBello commented Jun 14, 2021

@Mayb3Nots is there an error in creating and adding songs in playlist in your part? I've tried it in my part but I got at error of "_CastError (type 'Future' is not a subtype of type 'FutureOr<List>' in type cast)"

@Mayb3Nots
Copy link
Author

Can u paste the full exception including stacktrace?

@TcBello
Copy link

TcBello commented Jun 15, 2021

[ERROR:flutter/lib/ui/ui_dart_state.cc(186)] Unhandled Exception: type 'Future' is not a subtype of type 'FutureOr<List>' in type cast
E/flutter ( 3764): #0 PlaylistInfo.removeSong
package:flutter_audio_query/src/playlist_info.dart:49

@TcBello
Copy link

TcBello commented Jun 15, 2021

from what I observed I got this errors all in PlaylistInfo class, not just removeSong() produces errors but also other methods

@Mayb3Nots
Copy link
Author

Mayb3Nots commented Jun 15, 2021

[ERROR:flutter/lib/ui/ui_dart_state.cc(186)] Unhandled Exception: type 'Future' is not a subtype of type 'FutureOr' in type cast
E/flutter ( 3764): #0 PlaylistInfo.removeSong
package:flutter_audio_query/src/playlist_info.dart:49

Should be fixed please use lastest commit thanks. any future error please open an issue at my fork repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants