Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run as the configured sbt-native-packager user instead of root #3286

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bpholt
Copy link
Contributor

@bpholt bpholt commented Feb 15, 2024

Fixes #3283.

This works for us—the container runs and is able to clone, make PRs, etc., when running as the default user (demiourgos728 / UID 1001).

For fresh installs, I don't think any changes are needed to how one would run the container. However, for existing installs where the containers has been writing to some persistent storage as root, there may be some permissions issues. I'm not sure how to handle that.

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.19%. Comparing base (752757f) to head (b931cb6).
Report is 236 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3286   +/-   ##
=======================================
  Coverage   91.19%   91.19%           
=======================================
  Files         167      167           
  Lines        3408     3408           
  Branches      304      304           
=======================================
  Hits         3108     3108           
  Misses        300      300           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@exoego exoego added breaking-change enhancement New feature or request labels Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scala Steward runs as root when using the published Docker image (but it probably shouldn't)
2 participants