A strawman for aggregate literals #21993
Draft
+505
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A test case that shows that we can have an "inline type class" that allows to use a typeclass-based scheme for sequence literals where instances can be created with macros.
Also: Move test to run
We now don't try to instantiate selected type variables. Instead, we use a default as fallback if the expected type is underspecified according to the definition in Implicits. This is simpler and more expressive.
odersky
force-pushed
the
try-seqliterals
branch
from
a728906
to
6e904fb
Compare
|
From the doc I understand that implicit conversions are not applicable. Is weak conformance applicable? |
|
The successor of weak conformance (int literal widening) is usually applicable. That follows from the fact that SeqLiterals expand to varargs and varargs do perform that widening. |
tgodzik
reviewed
Nov 25, 2024
docs/_docs/internals/syntax.md
Outdated
| @@ -278,6 +278,7 @@ SimpleExpr ::= SimpleRef | |||
| | ‘new’ ConstrApp {‘with’ ConstrApp} [TemplateBody] New(constr | templ) | |||
| | ‘new’ TemplateBody | |||
| | ‘(’ ExprsInParens ‘)’ Parens(exprs) | |||
| | ‘[’ ExprInBrackets ‘)’ SeqLiteral(exprs, TypeTree()) | |||
There was a problem hiding this comment.
Suggested change
| | ‘[’ ExprInBrackets ‘)’ SeqLiteral(exprs, TypeTree()) | |
| | ‘[’ ExprInBrackets ‘]’ SeqLiteral(exprs, TypeTree()) |
just noticed while having a look
Also, test infix operations taking [...] as a right operand.
odersky
force-pushed
the
try-seqliterals
branch
from
3830475
to
599d51c
Compare
|
I got a crash in the repl by just having |
|
Also, maybe this is expected as its just for testing, but some of the instances for scala> val m: Set[Int] = [1,2,3]
1 warning found
-- Warning: --------------------------------------------------------------------
1 |val m: Set[Int] = [1,2,3]
| ^
|Given search preference for scala.compiletime.ExpressibleAsCollectionLiteral[Set[Int]] between alternatives
| scala.compiletime.ExpressibleAsCollectionLiteral.bitsetFromLiteral.type
|and
| (scala.compiletime.ExpressibleAsCollectionLiteral.setFromLiteral :
| [T]: scala.compiletime.ExpressibleAsCollectionLiteral.setFromLiteral[T])
|will change.
|Current choice : the first alternative
|New choice from Scala 3.7: none - it's ambiguous
val m: Set[Int] = BitSet(1, 2, 3) |
|
@bishabosha In fact, the given instances are set up so that it works properly only from 3.7 onwards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A test case that shows that we can have an "inline type class" that allows to use a typeclass-based scheme for sequence literals where instances can be created with macros.