-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine rules for capture parameters and members #22000
Open
noti0na1
wants to merge
7
commits into
scala:main
Choose a base branch
from
dotty-staging:make-cap-params-bounded-by-capset
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Refine rules for capture parameters and members #22000
noti0na1
wants to merge
7
commits into
scala:main
from
dotty-staging:make-cap-params-bounded-by-capset
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noti0na1
force-pushed
the
make-cap-params-bounded-by-capset
branch
from
November 22, 2024 09:59
651b674
to
c933560
Compare
TODO: fix override check for type members during CC |
noti0na1
force-pushed
the
make-cap-params-bounded-by-capset
branch
from
November 24, 2024 22:22
d016cce
to
a8c624e
Compare
noti0na1
changed the title
Make capture parameters and members bounded by CapSet by default
Refine rules for capture parameters and members
Nov 26, 2024
bracevac
reviewed
Nov 26, 2024
|
||
|
||
|
||
race[Either[T1, T2], Cap](left, right) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be necessary. I'll look into normalization and subtyping of captures.
Co-authored-by: Oliver Bračevac <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refines rules for capture variables (parameters and members).
Fix #21999, #22005
Add requirements for capture variables
When a capture set is encoded as a type, the type must refer to
CapSet
and bounded by>: CapSet <: CapSet^
.An unbounded capture parameter would be
C >: CapSet <: CapSet^
, which can be desugared fromC^
.Then, constaints between capture variables become possible:
Update definitions in the library
caps.scala
, such that a type following the rule can be used inside a capture set.Add cases to handle
CapSet
insubsumes