-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Limit bbox of volume tracings to that of fallback layer #7580
base: master
Are you sure you want to change the base?
Conversation
The backend part of this works now, frontend logging shows that the bbox in the volumetracing proto object is set to the fallback layer bbox. However, I noticed a few strange effects in the frontend
@philippotto can you estimate if these points would be easy to fix in the frontend? If not, maybe I’d defer the issue again (I just thought it would be a quick change in the backend). But this particular behavior is pretty weird and unexpected. |
Regarding the differing visibility of the volume bbox, I'd have to investigate why this is the case.
This is also known (see #5775). Each layer's bbox needs to be passed into the shader and then be handled accordingly. Both issues together might take approx. 2 hours ™️. |
Thanks for investigating! I think it would be worth tackling these two to three issues, but it certainly does not have the highest priority. I guess I’ll let this PR lie here until someone of the frontend team has some free capacity :) |
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
(Please delete unneeded items, merge only when none are left open)