bugfix: Use last modified time instead of creation time for detecting orphaned directories #2489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
force-pushed
the
debug-failing
branch
7 times, most recently
from
dd89b0d to
a93804e
Compare
tgodzik
changed the title
… orphaned directories Somehow this was an issue on linux and JDK 17, but not sure why not others. I also fixed getting stdout to get it redirected to the logger, my last change did not fully fix it.
tgodzik
force-pushed
the
debug-failing
branch
from
a93804e to
84ee587
Compare
tgodzik
commented
Nov 5, 2024
| @@ -292,7 +292,7 @@ object ClientInfo { | |||
| val dirName = clientDir.underlying.getFileName().toString | |||
| val attrs = | |||
| Files.readAttributes(clientDir.underlying, classOf[BasicFileAttributes]) | |||
| val isOldDir = attrs.creationTime.toInstant.isBefore(deletionThresholdInstant) | |||
| val isOldDir = attrs.lastModifiedTime.toInstant.isBefore(deletionThresholdInstant) | |||
There was a problem hiding this comment.
I think it's better to use last modified and it's possible to check in the tests actually.
adpi2
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow this was an issue on linux and JDK 17, but not sure why not others.
I also fixed getting stdout to get it redirected to the logger, my previous change did not fully fix it.