-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: initial setup #1
Conversation
github-app-id: 123456 | ||
github-app-key: ${{ secrets.APP_PRIVATE_KEY }} | ||
repos-file: 'repos.md' | ||
author-email: 123456+scala-center-steward[bot]@users.noreply.github.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have to wait for a pr to be sent in to get this ID as it's not the same as SCALA_STEWARD_APP_ID
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
- scalacenter/scalafix | ||
- scalacenter/scalafix.g8 | ||
- scalacenter/scalajs-bundler | ||
- scalacenter/scala-3-migration-guide |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don’t know if we still maintain this repo since the content has been included in docs.scala-lang. @adpi2, should we have the Steward here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll merge now just to see if this all works. If you want to remove the migration guide, we can do it after, or even just edit the repos.md
@adpi2 .
As far as I understand, this is the case because the app is installed organization-wide, not repo-wide. |
Gotcha, we can try it out and if it doesn't work we'll know why 😆 |
Looks good! scalacenter/library-example#120 |
Couple things left to do:
scala-steward-app
is "installed" on all the repos in the repo.md file (including this repo). I don't have access to https://github.com/organizations/scalacenter/settings/apps/scala-center-steward/installations so can't verify this. @julienrf you'll have to do this part.EDIT: I'm going to change the order a bit for this. I'll confirm this works and then merge the other ones in.