Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initial setup #1

Merged
merged 1 commit into from
Nov 29, 2022
Merged

feat: initial setup #1

merged 1 commit into from
Nov 29, 2022

Conversation

ckipp01
Copy link
Member

@ckipp01 ckipp01 commented Nov 29, 2022

Couple things left to do:

EDIT: I'm going to change the order a bit for this. I'll confirm this works and then merge the other ones in.

github-app-id: 123456
github-app-key: ${{ secrets.APP_PRIVATE_KEY }}
repos-file: 'repos.md'
author-email: 123456+scala-center-steward[bot]@users.noreply.github.com
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to wait for a pr to be sent in to get this ID as it's not the same as SCALA_STEWARD_APP_ID.

armanbilge/diy-steward#1

@ckipp01 ckipp01 requested a review from julienrf November 29, 2022 11:19
Copy link
Contributor

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

README.md Show resolved Hide resolved
repos.md Outdated Show resolved Hide resolved
- scalacenter/scalafix
- scalacenter/scalafix.g8
- scalacenter/scalajs-bundler
- scalacenter/scala-3-migration-guide
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t know if we still maintain this repo since the content has been included in docs.scala-lang. @adpi2, should we have the Steward here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge now just to see if this all works. If you want to remove the migration guide, we can do it after, or even just edit the repos.md @adpi2 .

@julienrf
Copy link
Contributor

  • Ensure the scala-steward-app is "installed" on all the repos in the repo.md file (including this repo)

As far as I understand, this is the case because the app is installed organization-wide, not repo-wide.

@ckipp01
Copy link
Member Author

ckipp01 commented Nov 29, 2022

  • Ensure the scala-steward-app is "installed" on all the repos in the repo.md file (including this repo)

As far as I understand, this is the case because the app is installed organization-wide, not repo-wide.

Gotcha, we can try it out and if it doesn't work we'll know why 😆

@ckipp01 ckipp01 marked this pull request as ready for review November 29, 2022 12:43
@ckipp01 ckipp01 merged commit e88dd03 into scalacenter:main Nov 29, 2022
@ckipp01 ckipp01 deleted the setup branch November 29, 2022 12:43
@julienrf
Copy link
Contributor

Looks good! scalacenter/library-example#120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants