Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] add large-messages project #69

Merged
merged 4 commits into from
Jan 25, 2024
Merged

[feat] add large-messages project #69

merged 4 commits into from
Jan 25, 2024

Conversation

rouche-q
Copy link
Contributor

@rouche-q rouche-q commented Jan 23, 2024 •
edited
Loading

Summary

Checklist

  • I have reviewed this myself.
  • I have attached a README to my example. You can use this template as reference.
  • I have updated the project README to link my example.

Details

@Shillaker Shillaker assigned Shillaker and unassigned Shillaker Jan 24, 2024
Shillaker
Shillaker requested changes Jan 24, 2024
View reviewed changes
projects/large-messages/README.md Outdated Show resolved Hide resolved
projects/large-messages/README.md Outdated Show resolved Hide resolved
projects/large-messages/README.md Outdated Show resolved Hide resolved
projects/large-messages/README.md Outdated Show resolved Hide resolved
projects/large-messages/README.md Outdated Show resolved Hide resolved
projects/large-messages/README.md Outdated Show resolved Hide resolved
projects/large-messages/function/handler/large_messages.py Outdated Show resolved Hide resolved
projects/large-messages/upload_img.sh Show resolved Hide resolved
projects/large-messages/upload_img.sh Outdated Show resolved Hide resolved
projects/large-messages/upload_img.sh Outdated Show resolved Hide resolved
Bemilie
Bemilie requested changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@Bemilie Bemilie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 But can you add a link to your example in the main README.md under the projects section

@Shillaker
Copy link
Contributor

Nice one, looks great. Thanks!

@Shillaker Shillaker merged commit fd82634 into scaleway:main Jan 25, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bemilie Bemilie Bemilie requested changes

@Shillaker Shillaker Shillaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rouche-q @Shillaker @Bemilie