Fixup test and coverage improvement

scality · Dec 12, 2024 · 83a5d2b · 83a5d2b
1 parent e05c7b0
commit 83a5d2b
Showing 1 changed file with 25 additions and 1 deletion.
diff --git a/tests/unit/utils/LocationStatusStream.spec.js b/tests/unit/utils/LocationStatusStream.spec.js
@@ -87,7 +87,7 @@ describe('LocationStatusStream', () => {
         const lss = new LocationStatusStream('lifecycle', mongoConfig, pauseStub, null, FakeLogger);
         lss._locationStatusColl = {
             find: () => ({
-                toArray: sinon.stub().yields(null, locations),
+                toArray: sinon.stub().resolves(locations),
             }),
         };
         lss._initializeLocationStatuses(err => {
@@ -161,6 +161,30 @@ describe('LocationStatusStream', () => {
         });
     });
 
+    it('_initializeLocationStatuses:: should handle errors when fetching location statuses', done => {
+        const error = new Error('MongoDB error');
+        const lss = new LocationStatusStream('lifecycle', mongoConfig, null, null, FakeLogger);
+        lss._locationStatusColl = {
+            find: () => ({
+                toArray: sinon.stub().rejects(error),
+            }),
+        };
+        const errorSpy = sinon.spy(lss._log, 'error');
+        lss._initializeLocationStatuses(err => {
+            assert(err);
+            assert.strictEqual(err.message, 'MongoDB error');
+            assert(errorSpy.calledOnce);
+            assert(errorSpy.calledWith(
+                'Could not fetch location statuses from mongo',
+                sinon.match({
+                    method: 'ServiceStatusManager._initializeLocationStatuses',
+                    error: 'MongoDB error',
+                })
+            ));
+            return done();
+        });
+    });
+
     it('should use resumeAfter with mongo 3.6', done => {
         const lss = new LocationStatusStream('lifecycle', mongoConfig, null, null, FakeLogger);
         lss._mongoVersion = '3.6.2';