LifecycleQueuePopulator: avoid creating vaultClientWrapper when not n…

…eeded Issue: BB-622
scality · Nov 7, 2024 · fc9e8b7 · fc9e8b7
1 parent 840f6bf
commit fc9e8b7
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 10 deletions.
diff --git a/extensions/lifecycle/LifecycleQueuePopulator.js b/extensions/lifecycle/LifecycleQueuePopulator.js
@@ -39,14 +39,14 @@ class LifecycleQueuePopulator extends QueuePopulatorExtension {
         super(params);
         this._authConfig = params.authConfig;
 
-        this.vaultClientWrapper = new VaultClientWrapper(
-            LIFEYCLE_POPULATOR_CLIENT_ID,
-            params.vaultAdmin,
-            this._authConfig,
-            this.log,
-        );
-
-        if (this._authConfig.type === authTypeAssumeRole) {
+        if (this._authConfig?.type === authTypeAssumeRole) {
+            this.vaultClientWrapper = new VaultClientWrapper(
+                LIFEYCLE_POPULATOR_CLIENT_ID,
+                params.vaultAdmin,
+                this._authConfig,
+                this.log,
+            );
+
             this.vaultClientWrapper.init();
         }
 
@@ -238,6 +238,10 @@ class LifecycleQueuePopulator extends QueuePopulatorExtension {
     }
 
     _handleRestoreOp(entry) {
+        if (!this.vaultClientWrapper) {
+            return;
+        }
+
         if (entry.type !== 'put' ||
             entry.key.startsWith(mpuBucketPrefix)) {
             return;
@@ -391,6 +395,10 @@ class LifecycleQueuePopulator extends QueuePopulatorExtension {
     }
 
     _handleDeleteOp(entry) {
+        if (!this.vaultClientWrapper) {
+            return;
+        }
+
         const value = JSON.parse(entry.value);
 
         // if object is not archived there is nothing to do here

diff --git a/tests/unit/lifecycle/LifecycleQueuePopulator.spec.js b/tests/unit/lifecycle/LifecycleQueuePopulator.spec.js
@@ -106,6 +106,14 @@ describe('LifecycleQueuePopulator', () => {
         }, 100);
     }
 
+    describe('constructor', () => {
+        it('should not create vaultClientWrapper when no auth config passed', () => {
+            const params = {};
+            const lcqp = new LifecycleQueuePopulator(params);
+            assert.strictEqual(lcqp.vaultClientWrapper, undefined);
+        });
+    });
+
     describe('Producer', () => {
         let lcqp;
         beforeEach(() => {
@@ -387,7 +395,6 @@ describe('LifecycleQueuePopulator', () => {
         });
     });
 
-
     describe(':_handleDeleteOp', () => {
         const kafkaSendStub = sinon.stub().yields();
         const objMd = {
@@ -545,7 +552,9 @@ describe('LifecycleQueuePopulator', () => {
             },
         ].forEach(params => {
             it(params.it, () => {
-                lcqp.vaultClientWrapper.getAccountId = sinon.stub().yields(...params.getAccountIdResponse);
+                lcqp.vaultClientWrapper = {
+                    getAccountId: sinon.stub().yields(...params.getAccountIdResponse),
+                };
                 const timestamp = new Date();
                 const entry = {
                     type: params.type,