Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BB-432: remove useless kafka connectors #2441

Merged
merged 5 commits into from
Aug 29, 2023
Merged

BB-432: remove useless kafka connectors #2441

merged 5 commits into from
Aug 29, 2023

Conversation

Kerkesni
Copy link
Contributor

Issue: BB-432

  • Avoid spawning the connectors at startup
  • Delete connectors when no bucket is assigned to them

@bert-e
Copy link
Contributor

bert-e commented Aug 11, 2023

Hello kerkesni,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@Kerkesni Kerkesni force-pushed the improvement/BB-432-remove-useless-kafka-connectors branch 2 times, most recently from 7040f16 to 8491ca9 Compare August 11, 2023 16:23
@scality scality deleted a comment from bert-e Aug 11, 2023
@scality scality deleted a comment from bert-e Aug 11, 2023
@scality scality deleted a comment from bert-e Aug 11, 2023
@scality scality deleted a comment from bert-e Aug 11, 2023
@scality scality deleted a comment from bert-e Aug 11, 2023
@Kerkesni Kerkesni force-pushed the improvement/BB-432-remove-useless-kafka-connectors branch from 8491ca9 to 657a2c6 Compare August 16, 2023 08:25
@scality scality deleted a comment from bert-e Aug 16, 2023
@scality scality deleted a comment from bert-e Aug 16, 2023
@scality scality deleted a comment from bert-e Aug 16, 2023
@bert-e
Copy link
Contributor

bert-e commented Aug 16, 2023

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.5

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

@bert-e
Copy link
Contributor

bert-e commented Aug 16, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@scality scality deleted a comment from bert-e Aug 16, 2023
francoisferrand
francoisferrand reviewed Aug 17, 2023
View reviewed changes
Copy link
Contributor

@francoisferrand francoisferrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks mostly good, though a deeper refactoring should be done (eventually) to make the list really dynamic instead of virtually pre-creating it to a specified length.

@Kerkesni Kerkesni force-pushed the improvement/BB-432-remove-useless-kafka-connectors branch from 657a2c6 to c8e700d Compare August 17, 2023 14:44
@scality scality deleted a comment from bert-e Aug 17, 2023
@Kerkesni Kerkesni force-pushed the improvement/BB-432-remove-useless-kafka-connectors branch from c8e700d to 9723d8c Compare August 17, 2023 15:25
@scality scality deleted a comment from bert-e Aug 17, 2023
@bert-e
Copy link
Contributor

bert-e commented Aug 17, 2023

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.5

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

@bert-e
Copy link
Contributor

bert-e commented Aug 17, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@scality scality deleted a comment from bert-e Aug 17, 2023
@scality scality deleted a comment from bert-e Aug 17, 2023
@scality scality deleted a comment from bert-e Aug 17, 2023
@scality scality deleted a comment from bert-e Aug 17, 2023
@scality scality deleted a comment from bert-e Aug 17, 2023
@Kerkesni
Copy link
Contributor Author

/approve

@francoisferrand francoisferrand force-pushed the improvement/BB-432-remove-useless-kafka-connectors branch from 555b991 to e6ef0ee Compare August 24, 2023 16:11
@francoisferrand francoisferrand force-pushed the improvement/BB-432-remove-useless-kafka-connectors branch from e6ef0ee to 9df72f7 Compare August 28, 2023 15:42
Kerkesni and others added 3 commits August 28, 2023 18:42
@Kerkesni @francoisferrand
avoid creating connectors at startup
acc513c 
Issue: BB-432
@Kerkesni @francoisferrand
test destroying kafka connect connectors when no bucket assigned to them
2de1eec 
Issue: BB-432
@francoisferrand
Remove isOld from connectors metrics
f54ac5c 
This label is not really useful, and not used in dashboard anyway. So
best remove it instead of adding more logic to maintain it.

IssyeL BB-432
@francoisferrand francoisferrand force-pushed the improvement/BB-432-remove-useless-kafka-connectors branch from 9df72f7 to f54ac5c Compare August 28, 2023 16:42
@scality scality deleted a comment from Kerkesni Aug 29, 2023
@scality scality deleted a comment from bert-e Aug 29, 2023
@bert-e
Copy link
Contributor

bert-e commented Aug 29, 2023

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.5

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

@scality scality deleted a comment from bert-e Aug 29, 2023
@bert-e
Copy link
Contributor

bert-e commented Aug 29, 2023

Build failed

The build for commit did not succeed in branch w/8.7/improvement/BB-432-remove-useless-kafka-connectors.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Aug 29, 2023

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/8.6

  • ✔️ development/8.7

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.5

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Aug 29, 2023

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.6

  • ✔️ development/8.7

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.5

Please check the status of the associated issue BB-432.

Goodbye kerkesni.

@bert-e bert-e merged commit c93a9db into development/8.6 Aug 29, 2023
7 checks passed
@bert-e bert-e deleted the improvement/BB-432-remove-useless-kafka-connectors branch August 29, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francoisferrand francoisferrand francoisferrand approved these changes

@nicolas2bert nicolas2bert nicolas2bert approved these changes

@rachedbenmustapha rachedbenmustapha Awaiting requested review from rachedbenmustapha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kerkesni @bert-e @francoisferrand @nicolas2bert