PutObjectRetention and DeleteObject authorization optimization

[williamlardier]

Previously, we were dynamically calling the internal authorization API to check if the identity, when not an account, has the permission to bypass the governance lock configuration. This call sent request contexts with information we already have when authorizing the API, except the type of identity.

This commit introduces an optimization by including the Bypass action, when the header is set, directly when the API is authorized. If the identity is an account, the overhead is lower than doing another API call: no policy are evaluated.

Both PutObjectRetention and DeleteObject API calls are updated accordingly. Multi object delete can be improved but the complexity is higher, and is already subject for improvement in a dedicated ticket.

Unit tests updated for the list of actions to authorize, and logic is already covered by existing tests - tested on a real platform too with success.

[bert-e]

Hello williamlardier,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
/after_pull_request	Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval	Bypass the pull request author's approval	⭐
/bypass_build_status	Bypass the build and test status	⭐
/bypass_commit_size	Bypass the check on the size of the changeset TBA	⭐
/bypass_incompatible_branch	Bypass the check on the source branch prefix	⭐
/bypass_jira_check	Bypass the Jira issue check	⭐
/bypass_peer_approval	Bypass the pull request peers' approval	⭐
/bypass_leader_approval	Bypass the pull request leaders' approval	⭐
/approve	Instruct Bert-E that the author has approved the pull request.		✍️
/create_pull_requests	Allow the creation of integration pull requests.
/create_integration_branches	Allow the creation of integration branches.
/no_octopus	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity	Change review acceptance criteria from one reviewer at least to all reviewers
/wait	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
/help	Print Bert-E's manual in the pull request.
/status	Print Bert-E's current status in the pull request TBA
/clear	Remove all comments from Bert-E from the history TBA
/retry	Re-start a fresh build TBA
/build	Re-start a fresh build TBA
/force_reset	Delete integration branches & pull requests, and restart merge process from the beginning.
/reset	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

[bert-e]

Incorrect fix version

The Fix Version/s in issue CLDSRV-583 contains:

• None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

• 8.8.37

Please check the Fix Version/s of CLDSRV-583, or the target
branch of this pull request.

[bert-e]

Waiting for approval

The following approvals are needed before I can proceed with the merge:

• the author

• 2 peers

[williamlardier]

/approve

[bert-e]

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

• ✔️ development/8.8

The following branches will NOT be impacted:

• development/7.10
• development/7.4
• development/7.70
• development/8.6
• development/8.7

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

• Any commit you add on the source branch will trigger a new cycle after the
  current queue is merged.
• Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

[bert-e]

I have successfully merged the changeset of this pull request
into targetted development branches:

• ✔️ development/8.8

The following branches have NOT changed:

• development/7.10
• development/7.4
• development/7.70
• development/8.6
• development/8.7

Please check the status of the associated issue CLDSRV-583.

Goodbye williamlardier.