Improvement/wrlgs 12 dep upgrades #169

williamlardier · 2024-09-03T07:43:15Z

Bump package deps and fix CVEs
Update code to follow latest linter
No change needed in gha
Bump project version
Remove unused packages

bert-e · 2024-09-03T07:43:18Z

Hello williamlardier,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

bert-e · 2024-09-03T07:44:17Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

francoisferrand · 2024-09-03T08:58:31Z

.eslintrc

-{ "extends": "scality" }
+{
+    "extends": "scality",
+    "parserOptions": {


can't we move these the scality/guidelines package, to avoid copying/duplicating and maintaining different styles?

Actually I think we can just remove them and adapt the code. I'll give it a quick try.

Done, like that we don't need to change scality guidelines by disabling good practice rules...

francoisferrand · 2024-09-03T08:59:17Z

package.json

-    "markdownlint-cli": "^0.27.1",
-    "mocha": "^8.4.0",
+    "@babel/eslint-parser": "^7.25.1",
+    "eslint": "^8.57.0",


We cannot, it requires node 18+, but then we cannot use it in our projects because they're not yet upgraded to node 20, which would make this dependency not usable... Do we want to upgrade to eslintv9 now?

error @eslint/[email protected]: The engine "node" is incompatible with this module. Expected version "^18.18.0 || ^20.9.0 || >=21.1.0". Got "16.20.2" error Found incompatible module.

Now it uses eslint v9, I also removed almost all devdeps, are they are unused, we should only rely on the scality eslint configuration... This will simplify things and then we can really enforce a coding style everywhere.

Use resolution to fix some critical CVEs as the packages either do not include the fix, or are requiring recent node versions. Issue: WRLGS-12

The new lint version enforces more rules. Also, some existing codes were not following the best practises Issue: WRLGS-12

Issue: WRLGS-12

bert-e · 2024-09-04T12:43:34Z

Incorrect fix version

The Fix Version/s in issue WRLGS-12 contains:

8.1.6

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

8.1.6
8.2.0

Please check the Fix Version/s of WRLGS-12, or the target
branch of this pull request.

bert-e · 2024-09-04T12:43:38Z

Incorrect fix version

The Fix Version/s in issue WRLGS-12 contains:

8.1.6

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

8.2.0

Please check the Fix Version/s of WRLGS-12, or the target
branch of this pull request.

bert-e · 2024-09-04T12:46:11Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

Issue: WRLGS-12

Issue: WRLOGS-12

williamlardier · 2024-09-05T12:38:41Z

/approve

bert-e · 2024-09-05T12:38:49Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/8.2

The following branches have NOT changed:

development/6.4
development/7.10
development/7.4
development/8.0
development/8.1

Please check the status of the associated issue WRLGS-12.

Goodbye williamlardier.

The following options are set: approve

scality deleted a comment from bert-e Sep 3, 2024

williamlardier force-pushed the improvement/WRLGS-12-dep-upgrades branch from 994e264 to 0ab4ca3 Compare September 3, 2024 07:53

francoisferrand reviewed Sep 3, 2024

View reviewed changes

francoisferrand approved these changes Sep 3, 2024

View reviewed changes

williamlardier added 5 commits September 3, 2024 11:15

Bump package dependencies

7fac66b

Use resolution to fix some critical CVEs as the packages either do not include the fix, or are requiring recent node versions. Issue: WRLGS-12

Lint the code files

a6ce10d

The new lint version enforces more rules. Also, some existing codes were not following the best practises Issue: WRLGS-12

Update design and readme md with linter rules

35680ac

Issue: WRLGS-12

Remove custom linter rules

53d2d58

Issue: WRLGS-12

Update code to match scality guideline style

6ebbf0c

Issue: WRLGS-12

williamlardier force-pushed the improvement/WRLGS-12-dep-upgrades branch from 0ab4ca3 to fb7d4b1 Compare September 3, 2024 09:15

williamlardier requested review from benzekrimaha and KillianG September 3, 2024 09:54

williamlardier force-pushed the improvement/WRLGS-12-dep-upgrades branch from fb7d4b1 to e67c765 Compare September 4, 2024 12:43

williamlardier changed the base branch from development/8.1 to development/8.2 September 4, 2024 12:43

williamlardier force-pushed the improvement/WRLGS-12-dep-upgrades branch from e67c765 to a1f0f91 Compare September 4, 2024 12:45

williamlardier added 3 commits September 4, 2024 14:47

Remove unused dependencies from package.json

2aa7472

Issue: WRLGS-12

Update code to match linter

fe42ed9

Issue: WRLGS-12

Use node 20

7095f8b

Issue: WRLGS-12

williamlardier force-pushed the improvement/WRLGS-12-dep-upgrades branch from a1f0f91 to 9df0245 Compare September 4, 2024 12:47

KillianG approved these changes Sep 5, 2024

View reviewed changes

williamlardier force-pushed the improvement/WRLGS-12-dep-upgrades branch from 9df0245 to 2d43c65 Compare September 5, 2024 12:28

Migrate eslint config file to latest v9

e509654

Issue: WRLGS-12

williamlardier force-pushed the improvement/WRLGS-12-dep-upgrades branch from 2d43c65 to e9f5fa1 Compare September 5, 2024 12:30

Remove spaces from linter fixes

4eda7ad

Issue: WRLGS-12

Bump to 8.2.0

7bf334c

Issue: WRLOGS-12

williamlardier force-pushed the improvement/WRLGS-12-dep-upgrades branch from e9f5fa1 to 7bf334c Compare September 5, 2024 12:37

bert-e merged commit 7bf334c into development/8.2 Sep 5, 2024
1 check passed

bert-e deleted the improvement/WRLGS-12-dep-upgrades branch September 5, 2024 12:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improvement/wrlgs 12 dep upgrades #169

Improvement/wrlgs 12 dep upgrades #169

williamlardier commented Sep 3, 2024 •

edited

Loading

bert-e commented Sep 3, 2024

bert-e commented Sep 3, 2024

francoisferrand Sep 3, 2024

williamlardier Sep 3, 2024

williamlardier Sep 3, 2024

francoisferrand Sep 3, 2024

williamlardier Sep 3, 2024 •

edited

Loading

williamlardier Sep 4, 2024

bert-e commented Sep 4, 2024

bert-e commented Sep 4, 2024

bert-e commented Sep 4, 2024

williamlardier commented Sep 5, 2024

bert-e commented Sep 5, 2024

Improvement/wrlgs 12 dep upgrades #169

Improvement/wrlgs 12 dep upgrades #169

Conversation

williamlardier commented Sep 3, 2024 • edited Loading

bert-e commented Sep 3, 2024

Hello williamlardier,

bert-e commented Sep 3, 2024

Waiting for approval

francoisferrand Sep 3, 2024

Choose a reason for hiding this comment

williamlardier Sep 3, 2024

Choose a reason for hiding this comment

williamlardier Sep 3, 2024

Choose a reason for hiding this comment

francoisferrand Sep 3, 2024

Choose a reason for hiding this comment

williamlardier Sep 3, 2024 • edited Loading

Choose a reason for hiding this comment

williamlardier Sep 4, 2024

Choose a reason for hiding this comment

bert-e commented Sep 4, 2024

Incorrect fix version

bert-e commented Sep 4, 2024

Incorrect fix version

bert-e commented Sep 4, 2024

Waiting for approval

williamlardier commented Sep 5, 2024

bert-e commented Sep 5, 2024

williamlardier commented Sep 3, 2024 •

edited

Loading

williamlardier Sep 3, 2024 •

edited

Loading