Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPDV-4906] Add missing typing_extensions dependency #108

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

tomaz-s1
Copy link
Collaborator

@tomaz-s1 tomaz-s1 commented Jan 8, 2024

This pull request adds missing typing_extensions dependency to see if it fixes issues with some older Splunk versions which don't ship with / vendor that package.

TODO

  • Figure out if we can always add that dependency since missing dependency seems to be related to Splunk version and not Python version directly

@tomaz-s1 tomaz-s1 force-pushed the add_missing_dependency_typing_extensions branch from b99a53a to 97f0e95 Compare January 8, 2024 10:07
@tomaz-s1 tomaz-s1 changed the title Add missing typing_extensions dependency [DPDV-4906] Add missing typing_extensions dependency Jan 8, 2024
Splunk 8.2.x which can use oldeer Python version.
@tomaz-s1 tomaz-s1 force-pushed the add_missing_dependency_typing_extensions branch from 97f0e95 to d8a5638 Compare January 8, 2024 10:16
Copy link
Collaborator

@martin-majlis-s1 martin-majlis-s1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tomaz-s1 tomaz-s1 merged commit 3dad5c4 into main Jan 9, 2024
7 checks passed
@tomaz-s1 tomaz-s1 deleted the add_missing_dependency_typing_extensions branch January 9, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants