Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPDV-5997] feat: allow query all or selected accounts #127

Merged

Conversation

munna-shaik-s1
Copy link
Collaborator

@munna-shaik-s1 munna-shaik-s1 commented Apr 30, 2024

Jira Link: https://sentinelone.atlassian.net/browse/DPDV-5997

🥅 Goal

Allow to query all assigned accounts or specify list of accounts to query

🛠️ Solution

  • add support for AuthN tokens
  • allow query all assigned accounts via tenant parameter
  • allow query selected accounts via accountIds parameter

🏫 Testing

How the changes were tested

Copy link
Collaborator

@zdaratom-s1 zdaratom-s1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update PR description and title so its clear what is your goal

README.md Outdated Show resolved Hide resolved
globalConfig.json Outdated Show resolved Hide resolved
globalConfig.json Outdated Show resolved Hide resolved
TA_dataset/README/ta_dataset_settings.conf.spec Outdated Show resolved Hide resolved
TA_dataset/bin/dataset_api.py Outdated Show resolved Hide resolved
TA_dataset/bin/dataset_common.py Outdated Show resolved Hide resolved
TA_dataset/bin/dataset_common.py Show resolved Hide resolved
TA_dataset/bin/dataset_query.py Outdated Show resolved Hide resolved
TA_dataset/bin/dataset_search_command.py Outdated Show resolved Hide resolved
globalConfig.json Outdated Show resolved Hide resolved
@munna-shaik-s1 munna-shaik-s1 requested a review from zdaratom-s1 May 2, 2024 10:38
@zdaratom-s1 zdaratom-s1 changed the title [DPDV-5997] Support for all console Ids [DPDV-5997] feat: allow query all or selected accounts May 2, 2024
globalConfig.json Outdated Show resolved Hide resolved
globalConfig.json Outdated Show resolved Hide resolved
@munna-shaik-s1 munna-shaik-s1 requested a review from zdaratom-s1 May 3, 2024 06:29
Copy link
Collaborator

@zdaratom-s1 zdaratom-s1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more small improvement. Lets also fix existing tests and introduce new test covering new features.

TA_dataset/bin/dataset_api.py Outdated Show resolved Hide resolved
@munna-shaik-s1 munna-shaik-s1 requested a review from zdaratom-s1 May 7, 2024 11:15
@zdaratom-s1
Copy link
Collaborator

@zdaratom-s1
Copy link
Collaborator

Please rebase, test are fixed in main branch already

@zdaratom-s1 zdaratom-s1 changed the base branch from main to 5997 May 10, 2024 10:16
@zdaratom-s1 zdaratom-s1 merged commit cb94857 into scalyr:5997 May 10, 2024
6 of 7 checks passed
munna-shaik-s1 added a commit that referenced this pull request May 13, 2024
* [DPDV-5997] feat: allow query all or selected accounts (#127)

* [DPDV-5997] adding account and tenant to queries

* [DPDV-5997] lint fix

* [DPDV-5997] lint fix

* [DPDV-5997] updated config

* [DPDV-5997] updated documentation

* [DPDV-5997] updated auth token encryption

* [DPDV-5997]  pre-commit fix

* [DPDV-5997]  pre-commit fix

* [DPDV-5997]  review comments fix

* [DPDV-5997]  pre commit fix

* [DPDV-5997]  review comment fix

* [DPDV-5997]  pre-commit fix

* [DPDV-5997]  review comment fix

* [DPDV-5997]  pre-commit fix

* [DPDV-5997]  review comment fixes

* [DPDV-5997] pre-commit fixes

* [DPDV-5997] conflict fixes

* [DPDV-5997] fix: fixing the playwright errors

* [DPDV-5997] fix: rollback the changes of tests

* [DPDV-5997] fix:  new review comments fixes

* [DPDV-5997] fix:  lint fix

* [DPDV-5997] fix:  review comment fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants