-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DPDV-5997] feat: allow query all or selected accounts #127
[DPDV-5997] feat: allow query all or selected accounts #127
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update PR description and title so its clear what is your goal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more small improvement. Lets also fix existing tests and introduce new test covering new features.
TA_dataset/lib/dataset_query_api_client/api/default/post_queries.py
Outdated
Show resolved
Hide resolved
Please rebase, test are fixed in main branch already |
* [DPDV-5997] feat: allow query all or selected accounts (#127) * [DPDV-5997] adding account and tenant to queries * [DPDV-5997] lint fix * [DPDV-5997] lint fix * [DPDV-5997] updated config * [DPDV-5997] updated documentation * [DPDV-5997] updated auth token encryption * [DPDV-5997] pre-commit fix * [DPDV-5997] pre-commit fix * [DPDV-5997] review comments fix * [DPDV-5997] pre commit fix * [DPDV-5997] review comment fix * [DPDV-5997] pre-commit fix * [DPDV-5997] review comment fix * [DPDV-5997] pre-commit fix * [DPDV-5997] review comment fixes * [DPDV-5997] pre-commit fixes * [DPDV-5997] conflict fixes * [DPDV-5997] fix: fixing the playwright errors * [DPDV-5997] fix: rollback the changes of tests * [DPDV-5997] fix: new review comments fixes * [DPDV-5997] fix: lint fix * [DPDV-5997] fix: review comment fix
Jira Link: https://sentinelone.atlassian.net/browse/DPDV-5997
🥅 Goal
Allow to query all assigned accounts or specify list of accounts to query
🛠️ Solution
🏫 Testing
How the changes were tested