[DPDV-3505] [DPDV-3507] Fix failing Playwright e2e tests and add-on name #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
everywhere. Some places still used "Security Data Lake...".
martin-majlis-s1
approved these changes
Sep 29, 2023
tmartin-s1
reviewed
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes the following changes:
1. Fix failing e2e tests
A couple of changes were merged recently (#82, #85) and those broke end to end tests.
This PR fixes all the failing tests and adds new checks for new built-in dashboards.
2. Fix Add-On Name
We have agreed on "Singularity Data Lake Add-On for Splunk" name, but some places still referenced "Security Data Lake Add-On for Splunk".
This PR fixes that and updates all the places to use "Singularity Data Lake Add-On for Splunk".