Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflows to use "concurrency" GHA functionality to skip redundant workflow runs #88

Merged
merged 4 commits into from
Sep 29, 2023

Conversation

tomaz-s1
Copy link
Collaborator

This pull request updates GHA workflow to utilize "concurrency" functionality so we skip / cancel redundant build runs for non-main branch workflow runs.

Relying on this native functionality instead of on skip-duplicate-jobs also allows to to reduce permissions we need for workflow runs.

@tomaz-s1
Copy link
Collaborator Author

I also pushed some changes which will hopefully make New Input - DataSet Alerts test less flaky.

Since alert evaluation and alert state reporting only happens every 1 minute, it means we need to wait at least 2-3 minutes after creating an alert input before checking for results otherwise there is a high chance of a failure.

It's worth noting that Playwright level retry won't do nothing in this situation since it simply retries the whole test.

@tomaz-s1 tomaz-s1 merged commit d43ffbf into main Sep 29, 2023
7 checks passed
@tomaz-s1 tomaz-s1 deleted the update_workflows branch September 29, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant