forked from cloudposse/terraform-aws-ec2-autoscale-group
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sync base from remote #2
Open
anoopsingh
wants to merge
46
commits into
scalyr:master
Choose a base branch
from
cloudposse:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Tony Thayer-Osborne <[email protected]>
## What * Adds chatops commands - '/test all' - '/test bats' - '/test readme' - '/test terratest' * Drops codefresh * Drops slash-command-dispatch * Removes codefresh badge * Rebuilds README ## Why * Change over from codefresh to GH Actions * Facilitate testing of PRs from forks
## What 1. Update Version Pinning for Terraform to support 0.13 ## Why 1. This is a relatively minor update that the CloudPosse module already likely supports. 1. This allows module consumers to not individually update our Terraform module to support Terraform 0.13.
* fix: update aws provider version for dep * Update versions.tf Co-authored-by: Vladimir <[email protected]> * Updated README.md Co-authored-by: Vladimir <[email protected]> Co-authored-by: actions-bot <[email protected]>
* adding custom alarms * fixing default * fixing default * Addin example for custom alarms * trying to merge both maps * trying to merge both maps * Updated README.md * trying to fix for_each for 0.12 * Update variables.tf Co-authored-by: Loren Gordon <[email protected]> * Auto Format * uping version of tf to 0.13 for_each required * Auto Format * making default alarms optional * Auto Format * Update variables.tf Co-authored-by: Andriy Knysh <[email protected]> * Auto Format * fixing conditional for default_alarms * fixing conditional for default_alarms * fixing space?????? * fixing space?????? * adding tags Co-authored-by: actions-bot <[email protected]> Co-authored-by: Loren Gordon <[email protected]> Co-authored-by: cloudpossebot <[email protected]> Co-authored-by: Andriy Knysh <[email protected]>
* adding custom alarms * fixing default * fixing default * Addin example for custom alarms * trying to merge both maps * trying to merge both maps * Updated README.md * trying to fix for_each for 0.12 * Update variables.tf Co-authored-by: Loren Gordon <[email protected]> * Auto Format * uping version of tf to 0.13 for_each required * Auto Format * making default alarms optional * Auto Format * Update variables.tf Co-authored-by: Andriy Knysh <[email protected]> * Auto Format * fixing conditional for default_alarms * fixing conditional for default_alarms * fixing space?????? * fixing space?????? * adding tags * Fixing merge of maps when maps do not have the same number of keys Co-authored-by: actions-bot <[email protected]> Co-authored-by: Loren Gordon <[email protected]> Co-authored-by: cloudpossebot <[email protected]> Co-authored-by: Andriy Knysh <[email protected]>
* Adding docs * Auto Format * Adding docs * Auto Format Co-authored-by: cloudpossebot <[email protected]>
Co-authored-by: maximmi <[email protected]>
…ed, readme updated (#50)
Co-authored-by: cloudpossebot <[email protected]>
…ped to 0.13.0 when needed, readme updated (#51)
* Add the instance_refresh block * Auto Format Co-authored-by: cloudpossebot <[email protected]>
* Fix README formatting * Auto Format Co-authored-by: cloudpossebot <[email protected]>
* Update README.yaml * Update README.yaml * Update README.yaml * Auto Format * Updated README.md Co-authored-by: cloudpossebot <[email protected]> Co-authored-by: actions-bot <[email protected]>
* var.use_name_prefix * Added contributor nitrocode * Auto Format Co-authored-by: cloudpossebot <[email protected]> Co-authored-by: actions-bot <[email protected]>
* Add max_instance_lifetime * Add max_instance_lifetime * Auto Format Co-authored-by: cloudpossebot <[email protected]>
* Add block_device_mappings example * Auto Format * Updated README.md Co-authored-by: cloudpossebot <[email protected]> Co-authored-by: actions-bot <[email protected]>
* Use dynamic for tag_specifications * Add var.tag_specifications_resource_types * Auto Format Co-authored-by: nitro <[email protected]> Co-authored-by: cloudpossebot <[email protected]> Co-authored-by: tthayer <[email protected]>
* add desired_capacity settings * update go modules * Use null * Use null * Auto Format Co-authored-by: nitro <[email protected]> Co-authored-by: cloudpossebot <[email protected]>
* Add metadata_http_tokens variable * Auto Format Co-authored-by: cloudpossebot <[email protected]> Co-authored-by: alexjurkiewicz <[email protected]> Co-authored-by: nitro <[email protected]> Co-authored-by: PePe Amengual <[email protected]>
Co-authored-by: cloudpossebot <[email protected]>
- When the instance profile is not specified terraform wants to continually add an empty block (tested in 0.14.x).
… it should be transparent for anyone going to use the new version (#73)
Co-authored-by: cloudpossebot <[email protected]>
* Add `update_default_lt_version` variable * Auto Format * Update variables.tf * Update variables.tf * Auto Format * Update main.tf Co-authored-by: cloudpossebot <[email protected]> Co-authored-by: nitrocode <[email protected]>
Co-authored-by: cloudpossebot <[email protected]> Co-authored-by: Yonatan Koren <[email protected]> * Add variable to enable/disable `metadata_options.http_protocol_ipv6` for launch templates.
Co-authored-by: cloudpossebot <[email protected]> * Remove unused providers: `hashicorp/template` and `hashicorp/null`.
* Run `make github/init`.
Co-authored-by: cloudpossebot <[email protected]>
* feat: fmt + force rebuild * feat: added support for metadata_options {instance_metadata_tags} * feat docs update for new option * Auto Format * Fix newlines and tests for versions.tf * Autodocumentation generation and release updates * Update aws provider to >= 4.0 * Regenerate docs post provider update Co-authored-by: Tomasz 'Zen' Napierala <[email protected]> Co-authored-by: cloudpossebot <[email protected]>
* Use tag and deprecate tags * Use tag.key and tag.value
* Add instance_reuse_policy for warm pool * Add instance_reuse_policy for warm pool * Update aws provider version * Revert updating aws provider version * Update aws provider version * Fix for when tag is null * Fix for when tag is null * Put back tags to fix error - The argument tag.4.value is required, but no definition was found * update tags for v4 * Fix tags for v4 when there is null value * Auto Format * revert terraform.md * Auto Format Co-authored-by: cloudpossebot <[email protected]>
* Add extended_statistic for custom CW alarm * Update README for extended_statistic * Auto Format * Fix extended_statistic for default alarms --------- Co-authored-by: cloudpossebot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why
references
closes #123
, if this PR closes a GitHub issue#123