Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default controls #532

Merged
merged 19 commits into from
Jul 24, 2023
Merged

Update default controls #532

merged 19 commits into from
Jul 24, 2023

Commits on Jul 20, 2023

  1. Update default controls

    - Consolidate default config
    - Update behavior for refresh scene inspector
    - Swap some mouse controls to get a slightly better compromise
    - Change zoom and FPS rotate keys
    kephale committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    8a5a89c View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2023

  1. Update default controls

    - Consolidate default config
    - Update behavior for refresh scene inspector
    - Swap some mouse controls to get a slightly better compromise
    - Change zoom and FPS rotate keys
    kephale authored and ctrueden committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    3a865ea View commit details
    Browse the repository at this point in the history
  2. Merge branch 'default-controls' of github.com:scenerygraphics/sciview…

    … into default-controls
    kephale committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    f43b0e0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fe55b3c View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2023

  1. Update default controls

    - Consolidate default config
    - Update behavior for refresh scene inspector
    - Swap some mouse controls to get a slightly better compromise
    - Change zoom and FPS rotate keys
    kephale authored and ctrueden committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    0685b80 View commit details
    Browse the repository at this point in the history
  2. WIP - start tidying up the control settings dialog

    The plan is to move the load/save persistence logic into
    ControlsParameters, so that it's always aligned with the actual model
    state. Then we can get rid of the PrefService and orig_* logic
    completely in the NavigationControlsSettings dialog, in favor of just
    getting the state from ControlsParameters upon dialog initialization,
    and setting the ControlsParameters state any time widgets change.
    ctrueden committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    92244ee View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6030285 View commit details
    Browse the repository at this point in the history
  4. Merge branch 'default-controls' of github.com:scenerygraphics/sciview…

    … into default-controls
    kephale committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    9c7de86 View commit details
    Browse the repository at this point in the history
  5. Split ControlsParameters defaults to constants

    And add a method to reset the values to defaults.
    ctrueden committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    ceb157e View commit details
    Browse the repository at this point in the history
  6. Persist controls params when they are changed

    And load them from persisted storage upon construction.
    ctrueden committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    5ca4c12 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    fe268e4 View commit details
    Browse the repository at this point in the history
  8. Simplify the NavigationControlsSettings

    * Set min/max/step in the annotation rather than via MutableModule API.
    * Replace checkbox hack logic with a refresh button.
    * Add a reset button to put the values back to defaults.
    * Add constants for magic numeric values.
    * Simplify initial control parameter value loading.
    * Fix case of FPS functions to match elsewhere in the codebase.
    * Downcase sciview.
    ctrueden committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    af2d419 View commit details
    Browse the repository at this point in the history
  9. Merge branch 'default-controls' of github.com:scenerygraphics/sciview…

    … into default-controls
    kephale committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    194cc20 View commit details
    Browse the repository at this point in the history
  10. Invert y-axis motion

    This could be simplified after
    scenerygraphics/scenery#591 is addressed
    kephale committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    17ae4c3 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    8c5efe8 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    78d03e2 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    acbd34b View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2023

  1. Configuration menu
    Copy the full SHA
    751564d View commit details
    Browse the repository at this point in the history
  2. Let max mouse scroll bound be much higher

    It maybe should not be bounded at all, because who knows what
    sizes of things people will be viewing inside of a sciview window.
    ctrueden committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    3cb4828 View commit details
    Browse the repository at this point in the history