-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instancing benchmark demo #586
Conversation
One concern I have is that if a user doesn't know what to expect when running this, they could have a pretty bad time (e.g. if they run the Maybe some kind of warning in the |
The last requests would be:
|
…es a name, className and a system property prefix
Added a benchmarking page to the docs and registered a gradle task to run the benchmark from a CLI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor things, otherwise great contribution! Thanks @smlpt 👍
src/main/kotlin/sc/iview/commands/demo/advanced/InstancingBenchmark.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/sc/iview/commands/demo/advanced/InstancingBenchmark.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/sc/iview/commands/demo/advanced/InstancingBenchmark.kt
Outdated
Show resolved
Hide resolved
@skalarproduktraum done 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @smlpt 👍
This PR adds a benchmark to the
Demo > Advanced
menu.It allows you to compare the conventional means of node publishing with instanced geometry, using spheres as objects.
The benchmark type can be run in four ways:
There are also parameters for the number of (instanced) particles (defaults to
1000
) and the spread in each dimension.